diff options
| author | Elias Naur <mail@eliasnaur.com> | 2019-11-15 18:30:19 -0500 |
|---|---|---|
| committer | Elias Naur <mail@eliasnaur.com> | 2020-02-26 09:47:21 +0000 |
| commit | e6d7326fb661f9754300d6b9fc5fbb2ee2e4a46b (patch) | |
| tree | 5901cfd8c50035232b34922b81abc98900cca8bd /src/cmd/go/internal/load/pkg.go | |
| parent | 42b93b7fe616b685e9ea41514b15bc9c26d3eac8 (diff) | |
| download | go-e6d7326fb661f9754300d6b9fc5fbb2ee2e4a46b.tar.gz go-e6d7326fb661f9754300d6b9fc5fbb2ee2e4a46b.zip | |
cmd/link: default to internal linking for android/arm64
The bootstrapping process (make.bash) on all other platforms use
internal linking. This change brings android/arm64 in line, fixing the
scary warning on our self-hosted Corellium builders:
warning: unable to find runtime/cgo.a
The linkmode default is changed to internal for all Android programs,
but in practice that won't matter outside our builders: using Go with
Android apps requires buildmode=c-shared which uses linkmode external.
Fixes #31343
Updates #31819
Change-Id: I3b3ada5ed69a7989e6d8e5960bbebf5e1c22aada
Reviewed-on: https://go-review.googlesource.com/c/go/+/207299
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/go/internal/load/pkg.go')
| -rw-r--r-- | src/cmd/go/internal/load/pkg.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go index 369a79b716..3e5d1f4023 100644 --- a/src/cmd/go/internal/load/pkg.go +++ b/src/cmd/go/internal/load/pkg.go @@ -1871,7 +1871,9 @@ func externalLinkingForced(p *Package) bool { // Some targets must use external linking even inside GOROOT. switch cfg.BuildContext.GOOS { case "android": - return true + if cfg.BuildContext.GOARCH != "arm64" { + return true + } case "darwin": switch cfg.BuildContext.GOARCH { case "arm", "arm64": |