diff options
| author | Bryan C. Mills <bcmills@google.com> | 2019-07-08 18:11:23 -0400 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2020-02-28 19:04:46 +0000 |
| commit | 156c60709e7775a6f1baa9685155b5974fefdea9 (patch) | |
| tree | 643dc8cf85c2d1aa0b29b1053ac37bea0b4e43dd /src/cmd/go/internal/load/pkg.go | |
| parent | d464c7ce29faa90ef2d35d5072c3e7c07606c525 (diff) | |
| download | go-156c60709e7775a6f1baa9685155b5974fefdea9.tar.gz go-156c60709e7775a6f1baa9685155b5974fefdea9.zip | |
cmd/go/internal/search: record errors in the Match struct
Previously, we would either invoke base.Fatalf (which is too aggressive),
or log.Print (which is too passive).
Updates #32917
Change-Id: I5475e873e76948de7df65dca08bc0ce67a7fc827
Reviewed-on: https://go-review.googlesource.com/c/go/+/185344
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/load/pkg.go')
| -rw-r--r-- | src/cmd/go/internal/load/pkg.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go index 3e5d1f4023..723985f1f8 100644 --- a/src/cmd/go/internal/load/pkg.go +++ b/src/cmd/go/internal/load/pkg.go @@ -2091,6 +2091,9 @@ func PackagesAndErrors(patterns []string) []*Package { seenPkg[p] = true pkgs = append(pkgs, p) } + + // TODO: if len(m.Pkgs) == 0 && len(m.Errs) > 0, should we add a *Package + // with a non-nil Error field? } // Now that CmdlinePkg is set correctly, |