diff options
| author | Obeyda Djeffal <djefobey@gmail.com> | 2020-04-16 12:45:37 +0100 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2020-10-15 15:40:06 +0000 |
| commit | aa161e799df7e1eba99d2be10271e76b6f758142 (patch) | |
| tree | 9dffb8ae65c4a89031df8f15db142c1b29ec12fc /src/cmd/go/internal/envcmd/env.go | |
| parent | 8cd75f3da094931c59636b85a87b4f680a208799 (diff) | |
| download | go-aa161e799df7e1eba99d2be10271e76b6f758142.tar.gz go-aa161e799df7e1eba99d2be10271e76b6f758142.zip | |
cmd/go: make sure CC and CXX are absolute
Add check in cmd/go/internal/work.BuildInit and
cmd/go/internal/envcmd.checkEnvWrite.
Fixes #38372
Change-Id: I196ea93a0469e4667ef785f7c1dc4574bdf7ff78
Reviewed-on: https://go-review.googlesource.com/c/go/+/228517
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Trust: Michael Matloob <matloob@golang.org>
Diffstat (limited to 'src/cmd/go/internal/envcmd/env.go')
| -rw-r--r-- | src/cmd/go/internal/envcmd/env.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/go/internal/envcmd/env.go b/src/cmd/go/internal/envcmd/env.go index 59d0ded658..b5a48558fa 100644 --- a/src/cmd/go/internal/envcmd/env.go +++ b/src/cmd/go/internal/envcmd/env.go @@ -424,6 +424,11 @@ func checkEnvWrite(key, val string) error { if !filepath.IsAbs(val) && val != "" { return fmt.Errorf("GOPATH entry is relative; must be absolute path: %q", val) } + // Make sure CC and CXX are absolute paths + case "CC", "CXX": + if !filepath.IsAbs(val) && val != "" && val != filepath.Base(val) { + return fmt.Errorf("%s entry is relative; must be absolute path: %q", key, val) + } } if !utf8.ValidString(val) { |