diff options
| author | Baokun Lee <bk@golangcn.org> | 2021-01-18 14:41:20 +0800 |
|---|---|---|
| committer | Baokun Lee <bk@golangcn.org> | 2021-03-02 03:46:25 +0000 |
| commit | 4c1a7ab49c4c68907bc7f7f7f776edd9116584a5 (patch) | |
| tree | d9ea4341bd0218cdd7be322163fb7437632f3fdc /src/cmd/go/internal/envcmd/env.go | |
| parent | 580636a78a8e2462f4c5cbbac04c6403c81401ff (diff) | |
| download | go-4c1a7ab49c4c68907bc7f7f7f776edd9116584a5.tar.gz go-4c1a7ab49c4c68907bc7f7f7f776edd9116584a5.zip | |
cmd/go: reject relative paths in GOMODCACHE environment
Go already rejects relative paths in a couple environment variables,
It should reject relative paths in GOMODCACHE.
Fixes #43715
Change-Id: Id1ceff839c7ab21c00cf4ace45ce48324733a526
Reviewed-on: https://go-review.googlesource.com/c/go/+/284432
Run-TryBot: Baokun Lee <bk@golangcn.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Trust: Baokun Lee <bk@golangcn.org>
Diffstat (limited to 'src/cmd/go/internal/envcmd/env.go')
| -rw-r--r-- | src/cmd/go/internal/envcmd/env.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/go/internal/envcmd/env.go b/src/cmd/go/internal/envcmd/env.go index 6937187522..aad5d704e5 100644 --- a/src/cmd/go/internal/envcmd/env.go +++ b/src/cmd/go/internal/envcmd/env.go @@ -428,7 +428,7 @@ func checkEnvWrite(key, val string) error { return fmt.Errorf("GOPATH entry is relative; must be absolute path: %q", val) } // Make sure CC and CXX are absolute paths - case "CC", "CXX": + case "CC", "CXX", "GOMODCACHE": if !filepath.IsAbs(val) && val != "" && val != filepath.Base(val) { return fmt.Errorf("%s entry is relative; must be absolute path: %q", key, val) } |