diff options
| author | Rob Pike <r@golang.org> | 2018-10-17 22:32:27 +1100 |
|---|---|---|
| committer | Daniel Martí <mvdan@mvdan.cc> | 2018-10-17 12:42:41 +0000 |
| commit | a2381f59662f8118c5cd78baaa90e8b186947e8f (patch) | |
| tree | f1e0499f135d59ff7d8600a731099844d82c442f /src/cmd/doc | |
| parent | 101a677ebf87f6ed0ed877533c54c7270edadc20 (diff) | |
| download | go-a2381f59662f8118c5cd78baaa90e8b186947e8f.tar.gz go-a2381f59662f8118c5cd78baaa90e8b186947e8f.zip | |
cmd/doc: fix repeated header bug added in previous CL
One too many lines was deleted, and it would print a header multiple times.
Add a test.
Change-Id: I4906b454dbb66193d515ffacf43849ffdc2dede6
Reviewed-on: https://go-review.googlesource.com/c/142937
Reviewed-by: Ralph Corderoy <ralph@inputplus.co.uk>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd/doc')
| -rw-r--r-- | src/cmd/doc/doc_test.go | 3 | ||||
| -rw-r--r-- | src/cmd/doc/pkg.go | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go index 80fdb5c72e..ec3a50d87d 100644 --- a/src/cmd/doc/doc_test.go +++ b/src/cmd/doc/doc_test.go @@ -733,6 +733,9 @@ func TestDoc(t *testing.T) { failed = true } } + if bytes.Count(output, []byte("TYPES\n")) > 1 { + t.Fatalf("%s: repeating headers", test.name) + } if failed { t.Logf("\n%s", output) } diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go index bb1b998537..680f555f59 100644 --- a/src/cmd/doc/pkg.go +++ b/src/cmd/doc/pkg.go @@ -426,6 +426,7 @@ func (pkg *Package) allDoc() { printHdr := func(s string) { if hdr != s { pkg.Printf("\n%s\n\n", s) + hdr = s } } |