diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2021-07-07 13:18:42 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2021-07-07 22:29:01 +0000 |
| commit | 5c59e11f5e1fe2e6d5b684f9a348022c07807126 (patch) | |
| tree | 53f266c4c11585eeaf31acdb66d0072b373f7ec5 /src/cmd/compile/internal/types | |
| parent | b003a8b1ae26fa684ec35eb7543efa1ded1bcae7 (diff) | |
| download | go-5c59e11f5e1fe2e6d5b684f9a348022c07807126.tar.gz go-5c59e11f5e1fe2e6d5b684f9a348022c07807126.zip | |
cmd/compile: remove special-casing of blank in types.sconv{,2}
I'm not sure why blank was special-cased here before, but it's
wrong. Blank is a non-exported identifier, and writing it out without
package-qualification can result in linker symbol collisions.
Fixes #47087.
Change-Id: Ie600037c8e54e3d4fdaeec21e2ca212badbd830b
Reviewed-on: https://go-review.googlesource.com/c/go/+/333163
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/types')
| -rw-r--r-- | src/cmd/compile/internal/types/fmt.go | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/cmd/compile/internal/types/fmt.go b/src/cmd/compile/internal/types/fmt.go index 7b284aa661..8b988952a7 100644 --- a/src/cmd/compile/internal/types/fmt.go +++ b/src/cmd/compile/internal/types/fmt.go @@ -109,10 +109,6 @@ func sconv(s *Sym, verb rune, mode fmtMode) string { return "<S>" } - if s.Name == "_" { - return "_" - } - q := pkgqual(s.Pkg, verb, mode) if q == "" { return s.Name @@ -136,10 +132,6 @@ func sconv2(b *bytes.Buffer, s *Sym, verb rune, mode fmtMode) { b.WriteString("<S>") return } - if s.Name == "_" { - b.WriteString("_") - return - } symfmt(b, s, verb, mode) } |