diff options
| author | Dan Scales <danscales@google.com> | 2021-07-07 12:03:41 -0700 |
|---|---|---|
| committer | Dan Scales <danscales@google.com> | 2021-07-07 22:57:23 +0000 |
| commit | 60cb2cab97ca6a28dcb4a58776ed85f840f534d5 (patch) | |
| tree | 5b5bcfe088089e1624eb13ebe7210ae95df2319a /src/cmd/compile/internal/types2/subst.go | |
| parent | 85267f402c3ba7ec91a3cf5e4e4a763fd1137deb (diff) | |
| download | go-60cb2cab97ca6a28dcb4a58776ed85f840f534d5.tar.gz go-60cb2cab97ca6a28dcb4a58776ed85f840f534d5.zip | |
[dev.typeparams] cmd/compile: fix bug with types2.Instantiate with interface type param
types2.subst has an assertion that check is non-nil, but which breaks
Instantiate() with an interface type param (used when re-importing
instatiated type to types2). But this check was added when Instantiate()
was added, and things seem to work fine when the assertion is removed.
Fixes test/typeparam/mdempsky/7.go.
Change-Id: I4980f0b202a0b310a3c91a7a87f97576f54911de
Reviewed-on: https://go-review.googlesource.com/c/go/+/333155
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Dan Scales <danscales@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types2/subst.go')
| -rw-r--r-- | src/cmd/compile/internal/types2/subst.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/types2/subst.go b/src/cmd/compile/internal/types2/subst.go index db01c36f7a..7b4796fa2e 100644 --- a/src/cmd/compile/internal/types2/subst.go +++ b/src/cmd/compile/internal/types2/subst.go @@ -313,9 +313,6 @@ func (subst *subster) typ(typ Type) Type { embeddeds, ecopied := subst.typeList(t.embeddeds) if mcopied || ecopied { iface := &Interface{methods: methods, embeddeds: embeddeds, complete: t.complete} - if subst.check == nil { - panic("internal error: cannot instantiate interfaces yet") - } return iface } |