diff options
| author | Robert Griesemer <gri@golang.org> | 2021-08-25 18:13:28 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2021-08-26 17:18:58 +0000 |
| commit | d6bdae33e918f779e9e50c020d32042e569368e2 (patch) | |
| tree | 6501f50076254d35b8907513c626461724071f42 /src/cmd/compile/internal/types2/self_test.go | |
| parent | 770df2e18df01e64f8770301b0d3a5d6bfa04027 (diff) | |
| download | go-d6bdae33e918f779e9e50c020d32042e569368e2.tar.gz go-d6bdae33e918f779e9e50c020d32042e569368e2.zip | |
cmd/compile/internal/types2: address some TODOs (cleanup)
- Address some easy TODOs.
- Remove some TODOs that are not correct anymore or are unimportent.
- Simplify some code on the way.
Change-Id: I4d20de3725b3a735022afe022cbc002b2798936d
Reviewed-on: https://go-review.googlesource.com/c/go/+/345176
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types2/self_test.go')
| -rw-r--r-- | src/cmd/compile/internal/types2/self_test.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/cmd/compile/internal/types2/self_test.go b/src/cmd/compile/internal/types2/self_test.go index 4722fec988..e0d2e1b07a 100644 --- a/src/cmd/compile/internal/types2/self_test.go +++ b/src/cmd/compile/internal/types2/self_test.go @@ -24,12 +24,7 @@ func TestSelf(t *testing.T) { conf := Config{Importer: defaultImporter()} _, err = conf.Check("cmd/compile/internal/types2", files, nil) if err != nil { - // Importing go/constant doesn't work in the - // build dashboard environment. Don't report an error - // for now so that the build remains green. - // TODO(gri) fix this - t.Log(err) // replace w/ t.Fatal eventually - return + t.Fatal(err) } } |