diff options
| author | Robert Griesemer <gri@golang.org> | 2021-08-08 12:37:35 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2021-08-10 01:20:32 +0000 |
| commit | 508624f359f168cab32814f63d29a4305fb01588 (patch) | |
| tree | 7675eb28b04ed0a9cb0fc95c647eb7edbd775af7 /src/cmd/compile/internal/types2/expr.go | |
| parent | f5f79c47f900300e8ac962e73ae7c2c706489d67 (diff) | |
| download | go-508624f359f168cab32814f63d29a4305fb01588.tar.gz go-508624f359f168cab32814f63d29a4305fb01588.zip | |
[dev.typeparams] cmd/compile/internal/types2: expand is only required for *Named types
Now that the pointer identity for a *Named type doesn't change
anymore when going from lazy instantiated to actually instantiated
(= expanded) state, expand() only needs to be called when we deal
with *Named types and only if we care about a *Named type's internals.
Remove the expand function and respective calls for all types and
replace with specific t.expand() method calls where t is a *Named.
Change-Id: If82299360d60108b00adc4013b29399aec90b940
Reviewed-on: https://go-review.googlesource.com/c/go/+/340749
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types2/expr.go')
| -rw-r--r-- | src/cmd/compile/internal/types2/expr.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/types2/expr.go b/src/cmd/compile/internal/types2/expr.go index 008c2446fc..3c2b10cd7e 100644 --- a/src/cmd/compile/internal/types2/expr.go +++ b/src/cmd/compile/internal/types2/expr.go @@ -682,7 +682,6 @@ func (check *Checker) convertUntyped(x *operand, target Type) { // If x is a constant operand, the returned constant.Value will be the // representation of x in this context. func (check *Checker) implicitTypeAndValue(x *operand, target Type) (Type, constant.Value, errorCode) { - target = expand(target) if x.mode == invalid || isTyped(x.typ) || target == Typ[Invalid] { return x.typ, nil, 0 } |