diff options
author | Robert Griesemer <gri@golang.org> | 2021-03-18 17:15:05 -0700 |
---|---|---|
committer | Robert Griesemer <gri@golang.org> | 2021-03-25 04:06:37 +0000 |
commit | c69515c9fd19d9cca5f509cedd3de0aafd2d487f (patch) | |
tree | 29a779280b416189a73e794bea3b1528cb236741 /src/cmd/compile/internal/types2/expr.go | |
parent | 4889afe8f82433599a38b74808eb572f972d4ff9 (diff) | |
download | go-c69515c9fd19d9cca5f509cedd3de0aafd2d487f.tar.gz go-c69515c9fd19d9cca5f509cedd3de0aafd2d487f.zip |
cmd/compile/internal/types2: review of expr.go
The changes between (equivalent, and reviewed) go/types/expr.go
and expr.go can be seen by comparing patchset 1 and 2. The actual
changes are removing the "// UNREVIEWED" marker.
The primary differences to go/types/expr.go are:
- use of package syntax rather than ast
- no reporting of error codes in errors
- implicit conversions of untyped nil lead to a typed nil
(in go/types, nil remains untyped)
Change-Id: I1e235b20ebda597eb7ce597d1749f26431addde2
Reviewed-on: https://go-review.googlesource.com/c/go/+/303092
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types2/expr.go')
-rw-r--r-- | src/cmd/compile/internal/types2/expr.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/types2/expr.go b/src/cmd/compile/internal/types2/expr.go index 3706185817..2eb4ded465 100644 --- a/src/cmd/compile/internal/types2/expr.go +++ b/src/cmd/compile/internal/types2/expr.go @@ -1,4 +1,3 @@ -// UNREVIEWED // Copyright 2012 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. |