diff options
| author | Robert Griesemer <gri@golang.org> | 2021-08-04 12:57:23 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2021-08-05 19:37:01 +0000 |
| commit | f78d538858a2d9aae975b2e2c144d23bcc22c22e (patch) | |
| tree | 1db864f65d92302851e6f8a359e2caeec94f7bf2 /src/cmd/compile/internal/types2/errors.go | |
| parent | c5b6c36ddd0ecdee401c4e78da1addf64bdc6376 (diff) | |
| download | go-f78d538858a2d9aae975b2e2c144d23bcc22c22e.tar.gz go-f78d538858a2d9aae975b2e2c144d23bcc22c22e.zip | |
[dev.typeparams] cmd/compile/internal/types2: cleanup panic calls
End-users are not expected to deal with the details of panics,
so providing extra information such as an "internal error" prefix
or the name of the function invoking the panic are not helpful.
Remove unnecessary panic verbiage if it is readily available from
a stack trace (such as the function where it happens, and the fact
that is is an "internal error").
Change-Id: I5f86bae6d2cca7c04ce692d17257da7ddee206d7
Reviewed-on: https://go-review.googlesource.com/c/go/+/339969
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types2/errors.go')
| -rw-r--r-- | src/cmd/compile/internal/types2/errors.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/types2/errors.go b/src/cmd/compile/internal/types2/errors.go index 8c5e185f6c..a68273271b 100644 --- a/src/cmd/compile/internal/types2/errors.go +++ b/src/cmd/compile/internal/types2/errors.go @@ -88,7 +88,7 @@ func sprintf(qf Qualifier, format string, args ...interface{}) string { case nil: arg = "<nil>" case operand: - panic("internal error: should always pass *operand") + panic("got operand instead of *operand") case *operand: arg = operandString(a, qf) case syntax.Pos: @@ -148,7 +148,7 @@ func (check *Checker) sprintf(format string, args ...interface{}) string { func (check *Checker) report(err *error_) { if err.empty() { - panic("internal error: reporting no error") + panic("no error to report") } check.err(err.pos(), err.msg(check.qualifier), err.soft) } |