diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2020-12-13 10:35:20 -0800 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2020-12-15 07:53:10 +0000 |
| commit | 4c2d66f642286647b640bced33581e8b1665bfe8 (patch) | |
| tree | c7fa15c8c2bdfde48dd618f6545fcd8676aad146 /src/cmd/compile/internal/types/sym.go | |
| parent | 305d93ef84aed971145b3aa1bce1f9f389bc90c0 (diff) | |
| download | go-4c2d66f642286647b640bced33581e8b1665bfe8.tar.gz go-4c2d66f642286647b640bced33581e8b1665bfe8.zip | |
[dev.regabi] cmd/compile: use ir.Ident for imported identifiers
This CL substantially reworks how imported declarations are handled,
and fixes a number of issues with dot imports. In particular:
1. It eliminates the stub ir.Name declarations that are created
upfront during import-declaration processing, allowing this to be
deferred to when the declarations are actually needed. (Eventually,
this can be deferred even further so we never have to create ir.Names
w/ ONONAME, but this CL is already invasive/subtle enough.)
2. During noding, we now use ir.Idents to represent uses of imported
declarations, including of dot-imported declarations.
3. Unused dot imports are now reported after type checking, so that we
can correctly distinguish whether composite literal keys are a simple
identifier (struct literals) or expressions (array/slice/map literals)
and whether it might be a use of a dot-imported declaration.
4. It changes the "redeclared" error messages to report the previous
position information in the same style as other compiler error
messages that reference other source lines.
Passes buildall w/ toolstash -cmp.
Fixes #6428.
Fixes #43164.
Fixes #43167.
Updates #42990.
Change-Id: I40a0a780ec40daf5700fbc3cfeeb7300e1055981
Reviewed-on: https://go-review.googlesource.com/c/go/+/277713
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/types/sym.go')
| -rw-r--r-- | src/cmd/compile/internal/types/sym.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/types/sym.go b/src/cmd/compile/internal/types/sym.go index fcb095c53c..19f06fcf5b 100644 --- a/src/cmd/compile/internal/types/sym.go +++ b/src/cmd/compile/internal/types/sym.go @@ -38,8 +38,7 @@ type Sym struct { Block int32 // blocknumber to catch redeclaration Lastlineno src.XPos // last declaration for diagnostic - flags bitset8 - Origpkg *Pkg // original package for . import + flags bitset8 } const ( |