diff options
author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-02-19 13:50:42 +0700 |
---|---|---|
committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-03-04 06:36:17 +0000 |
commit | 4b8b2c58647af6f1979d8c53d886c8cd71c99e4b (patch) | |
tree | d04b4d1aa7a7b679ff06b3871260210d9948c2c3 /src/cmd/compile/internal/typecheck/typecheck.go | |
parent | 8c22874e4e804e29ca040599ec63bb9e35233acd (diff) | |
download | go-4b8b2c58647af6f1979d8c53d886c8cd71c99e4b.tar.gz go-4b8b2c58647af6f1979d8c53d886c8cd71c99e4b.zip |
cmd/compile: do not set type for OTYPE
That's an invalid operation and depend on gc.hidePanic to report error.
Updates #43311
Change-Id: Ib0761dcf4d9d2a23c41de7eff0376677a90b942e
Reviewed-on: https://go-review.googlesource.com/c/go/+/294033
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/typecheck/typecheck.go')
-rw-r--r-- | src/cmd/compile/internal/typecheck/typecheck.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/typecheck/typecheck.go b/src/cmd/compile/internal/typecheck/typecheck.go index e7d4e81672..240f0409e7 100644 --- a/src/cmd/compile/internal/typecheck/typecheck.go +++ b/src/cmd/compile/internal/typecheck/typecheck.go @@ -433,8 +433,8 @@ func typecheck(n ir.Node, top int) (res ir.Node) { case top&ctxType == 0 && n.Op() == ir.OTYPE && t != nil: if !n.Type().Broke() { base.Errorf("type %v is not an expression", n.Type()) + n.SetDiag(true) } - n.SetType(nil) case top&(ctxStmt|ctxExpr) == ctxStmt && !isStmt && t != nil: if !n.Diag() { |