diff options
author | Matthew Dempsky <mdempsky@google.com> | 2021-01-05 06:43:38 -0800 |
---|---|---|
committer | Matthew Dempsky <mdempsky@google.com> | 2021-01-05 15:42:33 +0000 |
commit | 77365c5ed739f4882020ff76b2a4f5bfe4e8fc9d (patch) | |
tree | 87e2eb4333d040e79d81241a6d6540b9e4a907aa /src/cmd/compile/internal/typecheck/func.go | |
parent | e09783cbc0a7142719c6210b4eda7b21daad91d5 (diff) | |
download | go-77365c5ed739f4882020ff76b2a4f5bfe4e8fc9d.tar.gz go-77365c5ed739f4882020ff76b2a4f5bfe4e8fc9d.zip |
[dev.regabi] cmd/compile: add Name.Canonical and move Byval
There's a bunch of code that wants to map closure variables back to
their original name, so add a single Name.Canonical method that they
can all use.
Also, move the Byval flag from being stored on individual closure
variables to being stored on the canonical variable.
Passes toolstash -cmp.
Change-Id: Ia3ef81af5a15783d09f04b4e274ce33df94518e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/281541
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'src/cmd/compile/internal/typecheck/func.go')
-rw-r--r-- | src/cmd/compile/internal/typecheck/func.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/typecheck/func.go b/src/cmd/compile/internal/typecheck/func.go index e4c3088225..8fdb33b145 100644 --- a/src/cmd/compile/internal/typecheck/func.go +++ b/src/cmd/compile/internal/typecheck/func.go @@ -110,8 +110,8 @@ func CaptureVars(fn *ir.Func) { outermost := v.Defn.(*ir.Name) // out parameters will be assigned to implicitly upon return. - if outermost.Class != ir.PPARAMOUT && !outermost.Addrtaken() && !outermost.Assigned() && v.Type().Size() <= 128 { - v.SetByval(true) + if outermost.Class != ir.PPARAMOUT && !outermost.Addrtaken() && !outermost.Assigned() && outermost.Type().Size() <= 128 { + outermost.SetByval(true) } else { outermost.SetAddrtaken(true) } |