diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2020-12-28 17:06:43 -0800 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2020-12-29 02:49:00 +0000 |
| commit | 6acbae4fcc640715efd01cb161a65e1e04fda3cb (patch) | |
| tree | 388b4f93df6d3aa1c03731bb82c1ab43c7245d4e /src/cmd/compile/internal/typecheck/expr.go | |
| parent | 4629f6a51da5afabbebe9616f65fbfe0675d6039 (diff) | |
| download | go-6acbae4fcc640715efd01cb161a65e1e04fda3cb.tar.gz go-6acbae4fcc640715efd01cb161a65e1e04fda3cb.zip | |
[dev.regabi] cmd/compile: address some ir TODOs
Previously, ODOTTYPE/ODOTTYPE2 were forced to reuse some available
Node fields for storing pointers to runtime type descriptors. This
resulted in awkward field types for TypeAssertExpr and AddrExpr.
This CL gives TypeAssertExpr proper fields for the runtime type
descriptors, and also tightens the field types as
possible/appropriate.
Passes toolstash -cmp.
Change-Id: I521ee7a1462affc5459de33a0de6c68a7d6416ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/280637
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
Diffstat (limited to 'src/cmd/compile/internal/typecheck/expr.go')
| -rw-r--r-- | src/cmd/compile/internal/typecheck/expr.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/typecheck/expr.go b/src/cmd/compile/internal/typecheck/expr.go index 0682548c27..29d7a08011 100644 --- a/src/cmd/compile/internal/typecheck/expr.go +++ b/src/cmd/compile/internal/typecheck/expr.go @@ -649,7 +649,7 @@ func tcDotType(n *ir.TypeAssertExpr) ir.Node { } if n.Ntype != nil { - n.Ntype = typecheck(n.Ntype, ctxType) + n.Ntype = typecheckNtype(n.Ntype) n.SetType(n.Ntype.Type()) n.Ntype = nil if n.Type() == nil { |