diff options
| author | Robert Griesemer <gri@golang.org> | 2018-02-14 20:54:28 -0800 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2018-02-15 16:41:24 +0000 |
| commit | 33eb0633e160460aaf0707b20b12f296159b77a6 (patch) | |
| tree | 1a58dd6f0fea09a15c1e7019170398f3744da79c /src/cmd/compile/internal/syntax/scanner_test.go | |
| parent | e7cbbbe9bb878b6ca4ce04fde645df1c8f1845bd (diff) | |
| download | go-33eb0633e160460aaf0707b20b12f296159b77a6.tar.gz go-33eb0633e160460aaf0707b20b12f296159b77a6.zip | |
cmd/compile/internal/syntax: don't assume (operator) ~ means operator ^
The scanner assumed that ~ really meant ^, which may be helpful when
coming from C. But ~ is not a valid Go token, and pretending that it
should be ^ can lead to confusing error messages. Better to be upfront
about it and complain about the invalid character in the first place.
This was code "inherited" from the original yacc parser which was
derived from a C compiler. It's 10 years later and we can probably
assume that people are less confused about C and Go.
Fixes #23587.
Change-Id: I8d8f9b55b0dff009b75c1530d729bf9092c5aea6
Reviewed-on: https://go-review.googlesource.com/94160
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/syntax/scanner_test.go')
| -rw-r--r-- | src/cmd/compile/internal/syntax/scanner_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/syntax/scanner_test.go b/src/cmd/compile/internal/syntax/scanner_test.go index 4bfe5871fa..0b7c2cfe43 100644 --- a/src/cmd/compile/internal/syntax/scanner_test.go +++ b/src/cmd/compile/internal/syntax/scanner_test.go @@ -343,7 +343,7 @@ func TestScanErrors(t *testing.T) { {"\U0001d7d8" /* 𝟘 */, "identifier cannot begin with digit U+1D7D8 '𝟘'", 0, 0}, {"foo\U0001d7d8_½" /* foo𝟘_½ */, "invalid identifier character U+00BD '½'", 0, 8 /* byte offset */}, - {"x + ~y", "bitwise complement operator is ^", 0, 4}, + {"x + ~y", "invalid character U+007E '~'", 0, 4}, {"foo$bar = 0", "invalid character U+0024 '$'", 0, 3}, {"const x = 0xyz", "malformed hex constant", 0, 12}, {"0123456789", "malformed octal constant", 0, 10}, |