diff options
| author | Robert Griesemer <gri@golang.org> | 2016-11-08 16:01:56 -0800 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2016-11-09 17:48:40 +0000 |
| commit | 60a9bf9f957d48856839873c6dcb699afe7da359 (patch) | |
| tree | 019a1a18499cc6238a505c845129977db25873d6 /src/cmd/compile/internal/syntax/printer_test.go | |
| parent | ad020477f4dfe731450b6dd3dd15ea43aab0d0f1 (diff) | |
| download | go-60a9bf9f957d48856839873c6dcb699afe7da359.tar.gz go-60a9bf9f957d48856839873c6dcb699afe7da359.zip | |
cmd/compile/internal/syntax: fix error handling for Read/Parse calls
- define syntax.Error for cleaner error reporting
- abort parsing after first error if no error handler is installed
- make sure to always report the first error, if any
- document behavior of API calls
- while at it: rename ReadXXX -> ParseXXX (clearer)
- adjust cmd/compile noder.go accordingly
Fixes #17774.
Change-Id: I7893eedea454a64acd753e32f7a8bf811ddbb03c
Reviewed-on: https://go-review.googlesource.com/32950
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/syntax/printer_test.go')
| -rw-r--r-- | src/cmd/compile/internal/syntax/printer_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/syntax/printer_test.go b/src/cmd/compile/internal/syntax/printer_test.go index a2d43068dd..5c0fc776a1 100644 --- a/src/cmd/compile/internal/syntax/printer_test.go +++ b/src/cmd/compile/internal/syntax/printer_test.go @@ -15,7 +15,7 @@ func TestPrint(t *testing.T) { t.Skip("skipping test in short mode") } - ast, err := ReadFile(*src, nil, nil, 0) + ast, err := ParseFile(*src, nil, nil, 0) if err != nil { t.Fatal(err) } |