diff options
| author | Cherry Zhang <cherryyz@google.com> | 2017-03-13 21:51:08 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2017-03-16 14:25:04 +0000 |
| commit | c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1 (patch) | |
| tree | 9e37476d9604899a9283c845019a13acdc753802 /src/cmd/compile/internal/ssa/writebarrier_test.go | |
| parent | d75925d6bad2576bd80c442ff3b23ba22ffb2c68 (diff) | |
| download | go-c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1.tar.gz go-c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1.zip | |
cmd/compile: use type information in Aux for Store size
Remove size AuxInt in Store, and alignment in Move/Zero. We still
pass size AuxInt to Move/Zero, as it is used for partial Move/Zero
lowering (e.g. cmd/compile/internal/ssa/gen/386.rules:288).
SizeAndAlign is gone.
Passes "toolstash -cmp" on std.
Change-Id: I1ca34652b65dd30de886940e789fcf41d521475d
Reviewed-on: https://go-review.googlesource.com/38150
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/writebarrier_test.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/writebarrier_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/ssa/writebarrier_test.go b/src/cmd/compile/internal/ssa/writebarrier_test.go index 422bc94c3f..a4e95f9310 100644 --- a/src/cmd/compile/internal/ssa/writebarrier_test.go +++ b/src/cmd/compile/internal/ssa/writebarrier_test.go @@ -17,8 +17,8 @@ func TestWriteBarrierStoreOrder(t *testing.T) { Valu("sp", OpSP, TypeInvalid, 0, nil), Valu("v", OpConstNil, ptrType, 0, nil), Valu("addr1", OpAddr, ptrType, 0, nil, "sb"), - Valu("wb2", OpStore, TypeMem, 8, ptrType, "addr1", "v", "wb1"), - Valu("wb1", OpStore, TypeMem, 8, ptrType, "addr1", "v", "start"), // wb1 and wb2 are out of order + Valu("wb2", OpStore, TypeMem, 0, ptrType, "addr1", "v", "wb1"), + Valu("wb1", OpStore, TypeMem, 0, ptrType, "addr1", "v", "start"), // wb1 and wb2 are out of order Goto("exit")), Bloc("exit", Exit("wb2"))) @@ -44,7 +44,7 @@ func TestWriteBarrierPhi(t *testing.T) { Valu("phi", OpPhi, TypeMem, 0, nil, "start", "wb"), Valu("v", OpConstNil, ptrType, 0, nil), Valu("addr", OpAddr, ptrType, 0, nil, "sb"), - Valu("wb", OpStore, TypeMem, 8, ptrType, "addr", "v", "phi"), // has write barrier + Valu("wb", OpStore, TypeMem, 0, ptrType, "addr", "v", "phi"), // has write barrier Goto("loop"))) CheckFunc(fun.f) |