diff options
| author | Austin Clements <austin@google.com> | 2017-10-24 17:10:02 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2017-10-29 20:21:43 +0000 |
| commit | afbe646ab4480696d61462e9cab2ad048b5c1b6c (patch) | |
| tree | 0afc29efdb52fd3ceb5193e2b9277c41b5463543 /src/cmd/compile/internal/ssa/writebarrier.go | |
| parent | 507ca082d116c19cbe5cbdd457e6b37d851d2341 (diff) | |
| download | go-afbe646ab4480696d61462e9cab2ad048b5c1b6c.tar.gz go-afbe646ab4480696d61462e9cab2ad048b5c1b6c.zip | |
cmd/compile: report typedslicecopy write barriers
Most write barrier calls are inserted by SSA, but copy and append are
lowered to runtime.typedslicecopy during walk. Fix these to set
Func.WBPos and emit the "write barrier" warning, as done for the write
barriers inserted by SSA. As part of this, we refactor setting WBPos
and emitting this warning into the frontend so it can be shared by
both walk and SSA.
Change-Id: I5fe9997d9bdb55e03e01dd58aee28908c35f606b
Reviewed-on: https://go-review.googlesource.com/73411
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/writebarrier.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/writebarrier.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/cmd/compile/internal/ssa/writebarrier.go b/src/cmd/compile/internal/ssa/writebarrier.go index 129a06eecb..60797158b3 100644 --- a/src/cmd/compile/internal/ssa/writebarrier.go +++ b/src/cmd/compile/internal/ssa/writebarrier.go @@ -226,12 +226,7 @@ func writebarrier(f *Func) { if fn != nil { // Note that we set up a writebarrier function call. - if !f.WBPos.IsKnown() { - f.WBPos = pos - } - if f.fe.Debug_wb() { - f.Warnl(pos, "write barrier") - } + f.fe.SetWBPos(pos) } } |