diff options
| author | Michael Munday <mike.munday@ibm.com> | 2019-09-17 07:29:31 -0700 |
|---|---|---|
| committer | Michael Munday <mike.munday@ibm.com> | 2019-10-08 10:03:04 +0000 |
| commit | 6ec4c71eef730d56169255515fea3490c8a32650 (patch) | |
| tree | f458a868bc4cbbc0f48c5cf2d4d93d7d2dd887c5 /src/cmd/compile/internal/ssa/sizeof_test.go | |
| parent | 77f5adba554c80dc536f3076b2fa882d2cf0e992 (diff) | |
| download | go-6ec4c71eef730d56169255515fea3490c8a32650.tar.gz go-6ec4c71eef730d56169255515fea3490c8a32650.zip | |
cmd/compile: add SSA rules for s390x compare-and-branch instructions
This commit adds SSA rules for the s390x combined compare-and-branch
instructions. These have a shorter encoding than separate compare
and branch instructions and they also don't clobber the condition
code (a.k.a. flag register) reducing pressure on the flag allocator.
I have deleted the 'loop_test.go' file and replaced it with a new
codegen test which performs a wider range of checks.
Object sizes from compilebench:
name old object-bytes new object-bytes delta
Template 562kB ± 0% 561kB ± 0% -0.28% (p=0.000 n=10+10)
Unicode 217kB ± 0% 217kB ± 0% -0.17% (p=0.000 n=10+10)
GoTypes 2.03MB ± 0% 2.02MB ± 0% -0.59% (p=0.000 n=10+10)
Compiler 8.16MB ± 0% 8.11MB ± 0% -0.62% (p=0.000 n=10+10)
SSA 27.4MB ± 0% 27.0MB ± 0% -1.45% (p=0.000 n=10+10)
Flate 356kB ± 0% 356kB ± 0% -0.12% (p=0.000 n=10+10)
GoParser 438kB ± 0% 436kB ± 0% -0.51% (p=0.000 n=10+10)
Reflect 1.37MB ± 0% 1.37MB ± 0% -0.42% (p=0.000 n=10+10)
Tar 485kB ± 0% 483kB ± 0% -0.39% (p=0.000 n=10+10)
XML 630kB ± 0% 621kB ± 0% -1.45% (p=0.000 n=10+10)
[Geo mean] 1.14MB 1.13MB -0.60%
name old text-bytes new text-bytes delta
HelloSize 763kB ± 0% 754kB ± 0% -1.30% (p=0.000 n=10+10)
CmdGoSize 10.7MB ± 0% 10.6MB ± 0% -0.91% (p=0.000 n=10+10)
[Geo mean] 2.86MB 2.82MB -1.10%
Change-Id: Ibca55d9c0aa1254aee69433731ab5d26a43a7c18
Reviewed-on: https://go-review.googlesource.com/c/go/+/198037
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/sizeof_test.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/sizeof_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/ssa/sizeof_test.go b/src/cmd/compile/internal/ssa/sizeof_test.go index 8ba6a88b66..a17db87e8b 100644 --- a/src/cmd/compile/internal/ssa/sizeof_test.go +++ b/src/cmd/compile/internal/ssa/sizeof_test.go @@ -23,7 +23,7 @@ func TestSizeof(t *testing.T) { _64bit uintptr // size on 64bit platforms }{ {Value{}, 72, 112}, - {Block{}, 156, 296}, + {Block{}, 164, 304}, {LocalSlot{}, 32, 48}, {valState{}, 28, 40}, } |