diff options
| author | David Chase <drchase@google.com> | 2019-11-02 23:57:11 -0400 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2020-04-03 17:24:48 +0000 |
| commit | 47ade08141b23cfeafed92943e16012d5dc5eb8b (patch) | |
| tree | 0e38e95ad3de867e5151cf61e811c56999401a69 /src/cmd/compile/internal/ssa/rewriteMIPS.go | |
| parent | 3103495fa9bb166c9d0c56fbf3cd2146f32aef57 (diff) | |
| download | go-47ade08141b23cfeafed92943e16012d5dc5eb8b.tar.gz go-47ade08141b23cfeafed92943e16012d5dc5eb8b.zip | |
cmd/compile: add logging for large (>= 128 byte) copies
For 1.15, unless someone really wants it in 1.14.
A performance-sensitive user thought this would be useful,
though "large" was not well-defined. If 128 is large,
there are 139 static instances of "large" copies in the compiler
itself.
Includes test.
Change-Id: I81f20c62da59d37072429f3a22c1809e6fb2946d
Reviewed-on: https://go-review.googlesource.com/c/go/+/205066
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/rewriteMIPS.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/rewriteMIPS.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/ssa/rewriteMIPS.go b/src/cmd/compile/internal/ssa/rewriteMIPS.go index 5815874db9..9459a56b82 100644 --- a/src/cmd/compile/internal/ssa/rewriteMIPS.go +++ b/src/cmd/compile/internal/ssa/rewriteMIPS.go @@ -5263,7 +5263,7 @@ func rewriteValueMIPS_OpMove(v *Value) bool { return true } // match: (Move [s] {t} dst src mem) - // cond: (s > 16 || t.(*types.Type).Alignment()%4 != 0) + // cond: (s > 16 && logLargeCopy(v, s) || t.(*types.Type).Alignment()%4 != 0) // result: (LoweredMove [t.(*types.Type).Alignment()] dst src (ADDconst <src.Type> src [s-moveSize(t.(*types.Type).Alignment(), config)]) mem) for { s := v.AuxInt @@ -5271,7 +5271,7 @@ func rewriteValueMIPS_OpMove(v *Value) bool { dst := v_0 src := v_1 mem := v_2 - if !(s > 16 || t.(*types.Type).Alignment()%4 != 0) { + if !(s > 16 && logLargeCopy(v, s) || t.(*types.Type).Alignment()%4 != 0) { break } v.reset(OpMIPSLoweredMove) |