diff options
| author | Daniel Martí <mvdan@mvdan.cc> | 2019-09-19 15:31:03 +0100 |
|---|---|---|
| committer | Daniel Martí <mvdan@mvdan.cc> | 2019-09-23 16:36:10 +0000 |
| commit | 870080752d175d5cede350486acf36213c64f35c (patch) | |
| tree | 9fdf610cb118ed31f29a5c2f572870808cd18b49 /src/cmd/compile/internal/ssa/rewriteAMD64splitload.go | |
| parent | 34fe8295c5ac099109d7f8a1f967edec96f2a71d (diff) | |
| download | go-870080752d175d5cede350486acf36213c64f35c.tar.gz go-870080752d175d5cede350486acf36213c64f35c.zip | |
cmd/compile: reduce rulegen's output by 200 KiB
First, renove unnecessary "// cond:" lines from the generated files.
This shaves off about ~7k lines.
Second, join "if cond { break }" statements via "||", which allows us to
deduplicate a large number of them. This shaves off another ~25k lines.
This change is not for readability or simplicity; but rather, to avoid
unnecessary verbosity that makes the generated files larger. All in all,
git reports that the generated files overall weigh ~200KiB less, or
about 2.7% less.
While at it, add a -trace flag to rulegen.
Updates #33644.
Change-Id: I3fac0290a6066070cc62400bf970a4ae0929470a
Reviewed-on: https://go-review.googlesource.com/c/go/+/196498
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/rewriteAMD64splitload.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/rewriteAMD64splitload.go | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/cmd/compile/internal/ssa/rewriteAMD64splitload.go b/src/cmd/compile/internal/ssa/rewriteAMD64splitload.go index 2cccc8d4a1..a7aa51268d 100644 --- a/src/cmd/compile/internal/ssa/rewriteAMD64splitload.go +++ b/src/cmd/compile/internal/ssa/rewriteAMD64splitload.go @@ -28,7 +28,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPBconstload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPBconstload {sym} [vo] ptr mem) - // cond: // result: (CMPBconst (MOVBload {sym} [offOnly(vo)] ptr mem) [valOnly(vo)]) for { vo := v.AuxInt @@ -50,7 +49,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPBload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPBload {sym} [off] ptr x mem) - // cond: // result: (CMPB (MOVBload {sym} [off] ptr mem) x) for { off := v.AuxInt @@ -73,7 +71,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPLconstload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPLconstload {sym} [vo] ptr mem) - // cond: // result: (CMPLconst (MOVLload {sym} [offOnly(vo)] ptr mem) [valOnly(vo)]) for { vo := v.AuxInt @@ -95,7 +92,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPLload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPLload {sym} [off] ptr x mem) - // cond: // result: (CMPL (MOVLload {sym} [off] ptr mem) x) for { off := v.AuxInt @@ -118,7 +114,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPQconstload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPQconstload {sym} [vo] ptr mem) - // cond: // result: (CMPQconst (MOVQload {sym} [offOnly(vo)] ptr mem) [valOnly(vo)]) for { vo := v.AuxInt @@ -140,7 +135,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPQload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPQload {sym} [off] ptr x mem) - // cond: // result: (CMPQ (MOVQload {sym} [off] ptr mem) x) for { off := v.AuxInt @@ -163,7 +157,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPWconstload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPWconstload {sym} [vo] ptr mem) - // cond: // result: (CMPWconst (MOVWload {sym} [offOnly(vo)] ptr mem) [valOnly(vo)]) for { vo := v.AuxInt @@ -185,7 +178,6 @@ func rewriteValueAMD64splitload_OpAMD64CMPWload_0(v *Value) bool { b := v.Block typ := &b.Func.Config.Types // match: (CMPWload {sym} [off] ptr x mem) - // cond: // result: (CMPW (MOVWload {sym} [off] ptr mem) x) for { off := v.AuxInt |