diff options
| author | Giovanni Bajo <rasky@develer.com> | 2018-05-12 22:13:44 +0200 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2018-05-14 14:31:48 +0000 |
| commit | 67656ba71b54779d9f98995a12ed87e7c7618cad (patch) | |
| tree | 96d966243ec28054911c136e146b352b9ed77069 /src/cmd/compile/internal/ssa/poset_test.go | |
| parent | 7bac2a95f65418ec18d1fb5f30ae47e91980f30c (diff) | |
| download | go-67656ba71b54779d9f98995a12ed87e7c7618cad.tar.gz go-67656ba71b54779d9f98995a12ed87e7c7618cad.zip | |
cmd/compile: improve undo of poset
prove uses the poset datastructure in a DFS walk, and always undoes
it back to its pristine status. Before this CL, poset's undo of
a new node creation didn't fully deallocate the node, which means
that at the end of prove there was still some allocated memory pending.
This was not a problem until now because the posets used by prove
were discarded after each function, but it would prevent recycling
them between functions (as a followup CL does).
Change-Id: I1c1c99c03fe19ad765395a43958cb256f686765a
Reviewed-on: https://go-review.googlesource.com/112976
Run-TryBot: Giovanni Bajo <rasky@develer.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/poset_test.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/poset_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/ssa/poset_test.go b/src/cmd/compile/internal/ssa/poset_test.go index 899ac1ba06..89635ce54d 100644 --- a/src/cmd/compile/internal/ssa/poset_test.go +++ b/src/cmd/compile/internal/ssa/poset_test.go @@ -626,7 +626,6 @@ func TestPosetConst(t *testing.T) { func TestPosetNonEqual(t *testing.T) { testPosetOps(t, false, []posetTestOp{ - {Checkpoint, 0, 0}, {Equal_Fail, 10, 20}, {NonEqual_Fail, 10, 20}, |