aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/compile/internal/ssa/numberlines.go
diff options
context:
space:
mode:
authorDavid Chase <drchase@google.com>2019-10-01 11:05:59 -0400
committerDavid Chase <drchase@google.com>2019-10-04 16:54:10 +0000
commit33ab6ccba066d94f8b8f9f502fddf04df90ea8cd (patch)
tree8d050d143fa2184ff6ff121de0cc527f750df411 /src/cmd/compile/internal/ssa/numberlines.go
parent72dc3a0919bebbf166302a6fdac41ab8046d4a0f (diff)
downloadgo-33ab6ccba066d94f8b8f9f502fddf04df90ea8cd.tar.gz
go-33ab6ccba066d94f8b8f9f502fddf04df90ea8cd.zip
cmd/compile: don't attach statement marks to OpPhi
OpPhi nodes tend to disappear or get rearranged, and cause statement marks to vanish. Change-Id: I2f5a222903b7fcd0d1a72e8f6d7e156036b23f30 Reviewed-on: https://go-review.googlesource.com/c/go/+/198481 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jeremy Faller <jeremy@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/numberlines.go')
-rw-r--r--src/cmd/compile/internal/ssa/numberlines.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/ssa/numberlines.go b/src/cmd/compile/internal/ssa/numberlines.go
index 3e6afd72ff..68195e9b65 100644
--- a/src/cmd/compile/internal/ssa/numberlines.go
+++ b/src/cmd/compile/internal/ssa/numberlines.go
@@ -15,7 +15,7 @@ func isPoorStatementOp(op Op) bool {
switch op {
// Note that Nilcheck often vanishes, but when it doesn't, you'd love to start the statement there
// so that a debugger-user sees the stop before the panic, and can examine the value.
- case OpAddr, OpLocalAddr, OpOffPtr, OpStructSelect,
+ case OpAddr, OpLocalAddr, OpOffPtr, OpStructSelect, OpPhi,
OpIMake, OpStringMake, OpSliceMake, OpStructMake0, OpStructMake1, OpStructMake2, OpStructMake3, OpStructMake4,
OpConstBool, OpConst8, OpConst16, OpConst32, OpConst64, OpConst32F, OpConst64F:
return true