diff options
| author | Cherry Zhang <cherryyz@google.com> | 2017-03-13 21:51:08 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2017-03-16 14:25:04 +0000 |
| commit | c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1 (patch) | |
| tree | 9e37476d9604899a9283c845019a13acdc753802 /src/cmd/compile/internal/ssa/deadstore_test.go | |
| parent | d75925d6bad2576bd80c442ff3b23ba22ffb2c68 (diff) | |
| download | go-c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1.tar.gz go-c8f38b339875e020f50bedbdb8cfd8a7a1ef12b1.zip | |
cmd/compile: use type information in Aux for Store size
Remove size AuxInt in Store, and alignment in Move/Zero. We still
pass size AuxInt to Move/Zero, as it is used for partial Move/Zero
lowering (e.g. cmd/compile/internal/ssa/gen/386.rules:288).
SizeAndAlign is gone.
Passes "toolstash -cmp" on std.
Change-Id: I1ca34652b65dd30de886940e789fcf41d521475d
Reviewed-on: https://go-review.googlesource.com/38150
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/deadstore_test.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/deadstore_test.go | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/cmd/compile/internal/ssa/deadstore_test.go b/src/cmd/compile/internal/ssa/deadstore_test.go index beb6de0637..003b2284be 100644 --- a/src/cmd/compile/internal/ssa/deadstore_test.go +++ b/src/cmd/compile/internal/ssa/deadstore_test.go @@ -18,11 +18,11 @@ func TestDeadStore(t *testing.T) { Valu("addr1", OpAddr, ptrType, 0, nil, "sb"), Valu("addr2", OpAddr, ptrType, 0, nil, "sb"), Valu("addr3", OpAddr, ptrType, 0, nil, "sb"), - Valu("zero1", OpZero, TypeMem, 1, nil, "addr3", "start"), - Valu("store1", OpStore, TypeMem, 1, nil, "addr1", "v", "zero1"), - Valu("store2", OpStore, TypeMem, 1, nil, "addr2", "v", "store1"), - Valu("store3", OpStore, TypeMem, 1, nil, "addr1", "v", "store2"), - Valu("store4", OpStore, TypeMem, 1, nil, "addr3", "v", "store3"), + Valu("zero1", OpZero, TypeMem, 1, TypeBool, "addr3", "start"), + Valu("store1", OpStore, TypeMem, 0, TypeBool, "addr1", "v", "zero1"), + Valu("store2", OpStore, TypeMem, 0, TypeBool, "addr2", "v", "store1"), + Valu("store3", OpStore, TypeMem, 0, TypeBool, "addr1", "v", "store2"), + Valu("store4", OpStore, TypeMem, 0, TypeBool, "addr3", "v", "store3"), Goto("exit")), Bloc("exit", Exit("store3"))) @@ -54,7 +54,7 @@ func TestDeadStorePhi(t *testing.T) { Goto("loop")), Bloc("loop", Valu("phi", OpPhi, TypeMem, 0, nil, "start", "store"), - Valu("store", OpStore, TypeMem, 1, nil, "addr", "v", "phi"), + Valu("store", OpStore, TypeMem, 0, TypeBool, "addr", "v", "phi"), If("v", "loop", "exit")), Bloc("exit", Exit("store"))) @@ -79,8 +79,8 @@ func TestDeadStoreTypes(t *testing.T) { Valu("v", OpConstBool, TypeBool, 1, nil), Valu("addr1", OpAddr, t1, 0, nil, "sb"), Valu("addr2", OpAddr, t2, 0, nil, "sb"), - Valu("store1", OpStore, TypeMem, 1, nil, "addr1", "v", "start"), - Valu("store2", OpStore, TypeMem, 1, nil, "addr2", "v", "store1"), + Valu("store1", OpStore, TypeMem, 0, TypeBool, "addr1", "v", "start"), + Valu("store2", OpStore, TypeMem, 0, TypeBool, "addr2", "v", "store1"), Goto("exit")), Bloc("exit", Exit("store2"))) @@ -108,8 +108,8 @@ func TestDeadStoreUnsafe(t *testing.T) { Valu("sb", OpSB, TypeInvalid, 0, nil), Valu("v", OpConstBool, TypeBool, 1, nil), Valu("addr1", OpAddr, ptrType, 0, nil, "sb"), - Valu("store1", OpStore, TypeMem, 8, nil, "addr1", "v", "start"), // store 8 bytes - Valu("store2", OpStore, TypeMem, 1, nil, "addr1", "v", "store1"), // store 1 byte + Valu("store1", OpStore, TypeMem, 0, TypeInt64, "addr1", "v", "start"), // store 8 bytes + Valu("store2", OpStore, TypeMem, 0, TypeBool, "addr1", "v", "store1"), // store 1 byte Goto("exit")), Bloc("exit", Exit("store2"))) |