aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/compile/internal/ssa/deadcode.go
diff options
context:
space:
mode:
authorJosh Bleecher Snyder <josharian@gmail.com>2015-06-12 11:01:13 -0700
committerJosh Bleecher Snyder <josharian@gmail.com>2015-06-21 02:56:36 +0000
commit8c6abfeacb27f1bcce8fb01f7da95950590943e3 (patch)
tree3955f438422e5eb1ed3b3b1f789cd5af3c506ffa /src/cmd/compile/internal/ssa/deadcode.go
parent2aabacdb5aa4176f3c2916a096d8ac6934113562 (diff)
downloadgo-8c6abfeacb27f1bcce8fb01f7da95950590943e3.tar.gz
go-8c6abfeacb27f1bcce8fb01f7da95950590943e3.zip
[dev.ssa] cmd/compile/ssa: separate logging, work in progress, and fatal errors
The SSA implementation logs for three purposes: * debug logging * fatal errors * unimplemented features Separating these three uses lets us attempt an SSA implementation for all functions, not just _ssa functions. This turns the entire standard library into a compilation test, and makes it easy to figure out things like "how much coverage does SSA have now" and "what should we do next to get more coverage?". Functions called _ssa are still special. They log profusely by default and the output of the SSA implementation is used. For all other functions, logging is off, and the implementation is built and discarded, due to lack of support for the runtime. While we're here, fix a few minor bugs and add some extra Unimplementeds to allow all.bash to pass. As of now, SSA handles 20.79% of the functions in the standard library (689 of 3314). The top missing features are: 10.03% 2597 SSA unimplemented: zero for type error not implemented 7.79% 2016 SSA unimplemented: addr: bad op DOTPTR 7.33% 1898 SSA unimplemented: unhandled expr EQ 6.10% 1579 SSA unimplemented: unhandled expr OROR 4.91% 1271 SSA unimplemented: unhandled expr NE 4.49% 1163 SSA unimplemented: unhandled expr LROT 4.00% 1036 SSA unimplemented: unhandled expr LEN 3.56% 923 SSA unimplemented: unhandled stmt CALLFUNC 2.37% 615 SSA unimplemented: zero for type []byte not implemented 1.90% 492 SSA unimplemented: unhandled stmt CALLMETH 1.74% 450 SSA unimplemented: unhandled expr CALLINTER 1.74% 450 SSA unimplemented: unhandled expr DOT 1.71% 444 SSA unimplemented: unhandled expr ANDAND 1.65% 426 SSA unimplemented: unhandled expr CLOSUREVAR 1.54% 400 SSA unimplemented: unhandled expr CALLMETH 1.51% 390 SSA unimplemented: unhandled stmt SWITCH 1.47% 380 SSA unimplemented: unhandled expr CONV 1.33% 345 SSA unimplemented: addr: bad op * 1.30% 336 SSA unimplemented: unhandled OLITERAL 6 Change-Id: I4ca07951e276714dc13c31de28640aead17a1be7 Reviewed-on: https://go-review.googlesource.com/11160 Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/deadcode.go')
-rw-r--r--src/cmd/compile/internal/ssa/deadcode.go6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/cmd/compile/internal/ssa/deadcode.go b/src/cmd/compile/internal/ssa/deadcode.go
index 1a5589cd0a..f4884520de 100644
--- a/src/cmd/compile/internal/ssa/deadcode.go
+++ b/src/cmd/compile/internal/ssa/deadcode.go
@@ -4,8 +4,6 @@
package ssa
-import "log"
-
// deadcode removes dead code from f.
func deadcode(f *Func) {
@@ -82,7 +80,7 @@ func deadcode(f *Func) {
i++
} else {
if len(b.Values) > 0 {
- log.Panicf("live values in unreachable block %v: %v", b, b.Values)
+ b.Fatal("live values in unreachable block %v: %v", b, b.Values)
}
f.bid.put(b.ID)
}
@@ -105,7 +103,7 @@ func removePredecessor(b, c *Block) {
if n == 0 {
// c is now dead - don't bother working on it
if c.Preds[0] != b {
- log.Panicf("%s.Preds[0]==%s, want %s", c, c.Preds[0], b)
+ b.Fatal("%s.Preds[0]==%s, want %s", c, c.Preds[0], b)
}
return
}