diff options
| author | Philip Hofer <phofer@umich.edu> | 2016-11-14 17:05:46 -0800 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2016-11-18 16:31:27 +0000 |
| commit | a34fddf46c47a86e7a7cab32be858f7e8d0feb70 (patch) | |
| tree | eae010e50cd1264c4f9b5aada1f6ca55d067a198 /src/cmd/compile/internal/ssa/cse.go | |
| parent | 277bcbbdcd26f2d64493e596238e34b47782f98e (diff) | |
| download | go-a34fddf46c47a86e7a7cab32be858f7e8d0feb70.tar.gz go-a34fddf46c47a86e7a7cab32be858f7e8d0feb70.zip | |
cmd/compile: in cse, allow for new ssa values
The table of rewrites in ssa/cse is not sized appropriately for
ssa IDs that are created during copying of selects into new blocks.
Fixes #17918
Change-Id: I65fe86c6aab5efa679aa473aadc4ee6ea882cd41
Reviewed-on: https://go-review.googlesource.com/33240
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/cse.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/cse.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/ssa/cse.go b/src/cmd/compile/internal/ssa/cse.go index 9410433325..4e07c89b88 100644 --- a/src/cmd/compile/internal/ssa/cse.go +++ b/src/cmd/compile/internal/ssa/cse.go @@ -188,7 +188,10 @@ func cse(f *Func) { for _, b := range f.Blocks { out: for _, v := range b.Values { - if rewrite[v.ID] != nil { + // New values are created when selectors are copied to + // a new block. We can safely ignore those new values, + // since they have already been copied (issue 17918). + if int(v.ID) >= len(rewrite) || rewrite[v.ID] != nil { continue } if v.Op != OpSelect0 && v.Op != OpSelect1 { |