diff options
| author | David Chase <drchase@google.com> | 2019-09-30 11:12:29 -0400 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2019-10-03 21:12:13 +0000 |
| commit | adc4d2cc2dbc20c14bae7bbdbca8d75421e1bef5 (patch) | |
| tree | f859739b569fd3682291b60186cd41d55e85f229 /src/cmd/compile/internal/ssa/compile.go | |
| parent | 08a87938bb95ae8859600be20a998fbb4b904915 (diff) | |
| download | go-adc4d2cc2dbc20c14bae7bbdbca8d75421e1bef5.tar.gz go-adc4d2cc2dbc20c14bae7bbdbca8d75421e1bef5.zip | |
cmd/compile: run deadcode before nilcheck for better statement relocation
Nilcheck would move statements from NilCheck values to others that
turned out were already dead, which leads to lost statements. Better
to eliminate the dead code first.
One "error" is removed from test/prove.go because the code is
actually dead, and the additional deadcode pass removes it before
prove can run.
Change-Id: If75926ca1acbb59c7ab9c8ef14d60a02a0a94f8b
Reviewed-on: https://go-review.googlesource.com/c/go/+/198479
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/compile.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/compile.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/ssa/compile.go b/src/cmd/compile/internal/ssa/compile.go index f061b62448..1a0a46c154 100644 --- a/src/cmd/compile/internal/ssa/compile.go +++ b/src/cmd/compile/internal/ssa/compile.go @@ -409,6 +409,7 @@ var passes = [...]pass{ {name: "opt deadcode", fn: deadcode, required: true}, // remove any blocks orphaned during opt {name: "generic cse", fn: cse}, {name: "phiopt", fn: phiopt}, + {name: "gcse deadcode", fn: deadcode, required: true}, // clean out after cse and phiopt {name: "nilcheckelim", fn: nilcheckelim}, {name: "prove", fn: prove}, {name: "fuse plain", fn: fusePlain}, |