diff options
| author | Keith Randall <khr@golang.org> | 2020-06-15 14:43:02 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2020-06-18 20:57:49 +0000 |
| commit | 40ef1faabc44ab8ea28a1cf282ecab723ecb0394 (patch) | |
| tree | 1c04bdc4b2eb3226759499dd6867c6771510ba75 /src/cmd/compile/internal/ssa/check.go | |
| parent | 377c1536f548ae6295699475683db7574bea3d51 (diff) | |
| download | go-40ef1faabc44ab8ea28a1cf282ecab723ecb0394.tar.gz go-40ef1faabc44ab8ea28a1cf282ecab723ecb0394.zip | |
cmd/compile: redo flag constant ops for arm
Encode the flag results in an auxint field instead of having
one opcode per flag state. This helps us handle the new *noov
branches in a unified manner.
This is only for arm, arm64 is in a subsequent CL.
We could extend to other architectures as well, athough it would
only be cleanup, no behavioral change.
Update #39505
Change-Id: Ia46cea596faad540d1496c5915ab1274571543f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/238077
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/check.go')
| -rw-r--r-- | src/cmd/compile/internal/ssa/check.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/ssa/check.go b/src/cmd/compile/internal/ssa/check.go index 20ca28a54b..98e1b79334 100644 --- a/src/cmd/compile/internal/ssa/check.go +++ b/src/cmd/compile/internal/ssa/check.go @@ -185,6 +185,11 @@ func checkFunc(f *Func) { f.Fatalf("bad type %T for S390XRotateParams in %v", v.Aux, v) } canHaveAux = true + case auxFlagConstant: + if v.AuxInt < 0 || v.AuxInt > 15 { + f.Fatalf("bad FlagConstant AuxInt value for %v", v) + } + canHaveAuxInt = true default: f.Fatalf("unknown aux type for %s", v.Op) } |