diff options
author | Josh Bleecher Snyder <josharian@gmail.com> | 2015-07-24 20:09:39 -0700 |
---|---|---|
committer | Josh Bleecher Snyder <josharian@gmail.com> | 2015-07-27 17:24:54 +0000 |
commit | b61f8c8df3247945ef723a22df0327264adfa3f9 (patch) | |
tree | 376b56a449c1b627e8db844dd1844ea5f5047c42 /src/cmd/compile/internal/ssa/TODO | |
parent | 0bb2a50a55b15b7a9ea63cfa55a29e13ef29b542 (diff) | |
download | go-b61f8c8df3247945ef723a22df0327264adfa3f9.tar.gz go-b61f8c8df3247945ef723a22df0327264adfa3f9.zip |
[dev.ssa] cmd/compile: fix registers for in-place instructions
Some of these were right; others weren't.
Fixes 'GOGC=off GOSSAPKG=mime go test -a mime'.
The right long term fix is probably to teach the
register allocator about in-place instructions.
In the meantime, all the tests that we can run
now pass.
Change-Id: I8e37b00a5f5e14f241b427d45d5f5cc1064883a2
Reviewed-on: https://go-review.googlesource.com/12664
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/cmd/compile/internal/ssa/TODO')
-rw-r--r-- | src/cmd/compile/internal/ssa/TODO | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/ssa/TODO b/src/cmd/compile/internal/ssa/TODO index 225768c73c..f77c5ad8f3 100644 --- a/src/cmd/compile/internal/ssa/TODO +++ b/src/cmd/compile/internal/ssa/TODO @@ -28,6 +28,8 @@ Regalloc - Floating point registers - Make calls clobber all registers - Make liveness analysis non-quadratic. + - Handle in-place instructions (like XORQconst) directly: + Use XORQ AX, 1 rather than MOVQ AX, BX; XORQ BX, 1. StackAlloc: - Sort variables so all ptr-containing ones are first (so stack |