diff options
| author | Keith Randall <khr@golang.org> | 2016-01-29 21:57:57 -0800 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2016-02-05 16:38:45 +0000 |
| commit | aebf6611dfba195d15c5119e14d6f5b708adbdfb (patch) | |
| tree | a51c695d3453c197a15a6443260ad0b6b261b85d /src/cmd/compile/internal/ssa/TODO | |
| parent | a6fb514bf8dd43cff37185eb02b448d8244af9da (diff) | |
| download | go-aebf6611dfba195d15c5119e14d6f5b708adbdfb.tar.gz go-aebf6611dfba195d15c5119e14d6f5b708adbdfb.zip | |
[dev.ssa] cmd/compile: reorg write barriers a bit
Use just a single write barrier flag test, even if there
are multiple pointer fields in a struct.
This helps move more of the wb-specific code (like the LEA
needed to materialize the write address) into the unlikely path.
Change-Id: Ic7a67145904369c4ff031e464d51267d71281c8f
Reviewed-on: https://go-review.googlesource.com/19085
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ssa/TODO')
| -rw-r--r-- | src/cmd/compile/internal/ssa/TODO | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/ssa/TODO b/src/cmd/compile/internal/ssa/TODO index 73396c7637..5fa14ee44b 100644 --- a/src/cmd/compile/internal/ssa/TODO +++ b/src/cmd/compile/internal/ssa/TODO @@ -7,7 +7,6 @@ Coverage Correctness ----------- - Debugging info (check & fix as much as we can) -- Fix write barriers so cgo tests work (misc/cgo/errors/ptr.go) - Re-enable TestStackBarrierProfiling (src/runtime/pprof/pprof_test.go) - @ directive in rewrites might read overwritten data. Save @loc in variable before modifying v. @@ -25,7 +24,6 @@ Optimizations (better compiled code) SUBQ $8, AX CMP AX, $0 JEQ ... -- Use better write barrier calls - If there are a lot of MOVQ $0, ..., then load 0 into a register and use the register as the source instead. - Allow arrays of length 1 (or longer, with all constant indexes?) to be SSAable. |