diff options
| author | Keith Randall <khr@golang.org> | 2020-03-20 09:59:53 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2020-03-21 02:46:16 +0000 |
| commit | 287d67e3dd3972b1d1006b06e0d57929540a1591 (patch) | |
| tree | 41370522ce628db8fd817a30d284ca9d4674d600 /src/cmd/compile/internal/ppc64 | |
| parent | 5bc75a3097a3671055f0f9c503850edbe830601d (diff) | |
| download | go-287d67e3dd3972b1d1006b06e0d57929540a1591.tar.gz go-287d67e3dd3972b1d1006b06e0d57929540a1591.zip | |
cmd/compile: indexed loads/stores can't be faultOnNilArg0
Because of the index, these ops can't guarantee faulting if arg0 is nil.
Clean up the PPC64 index ops - they can't take a sym or an offset.
Noticed while debugging #37881. I don't think it is the cause, but I guess
there is a chance.
Update #37881
Change-Id: Ic22925250bf7b1ba64e3cea1a65638bc4bab390c
Reviewed-on: https://go-review.googlesource.com/c/go/+/224457
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/compile/internal/ppc64')
| -rw-r--r-- | src/cmd/compile/internal/ppc64/ssa.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/ppc64/ssa.go b/src/cmd/compile/internal/ppc64/ssa.go index ce30c9ae37..0ab21604e5 100644 --- a/src/cmd/compile/internal/ppc64/ssa.go +++ b/src/cmd/compile/internal/ppc64/ssa.go @@ -794,7 +794,6 @@ func ssaGenValue(s *gc.SSAGenState, v *ssa.Value) { p.From.Type = obj.TYPE_MEM p.From.Reg = v.Args[0].Reg() p.From.Index = v.Args[1].Reg() - gc.AddAux(&p.From, v) p.To.Type = obj.TYPE_REG p.To.Reg = v.Reg() @@ -823,7 +822,6 @@ func ssaGenValue(s *gc.SSAGenState, v *ssa.Value) { p.To.Index = v.Args[1].Reg() p.To.Type = obj.TYPE_MEM p.To.Reg = v.Args[0].Reg() - gc.AddAux(&p.To, v) case ssa.OpPPC64ISEL, ssa.OpPPC64ISELB: // ISEL, ISELB |