diff options
| author | Keith Randall <khr@golang.org> | 2021-07-24 14:11:27 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2021-07-24 22:49:24 +0000 |
| commit | b27c7e30dc5d222766057e62c16cb765b636d244 (patch) | |
| tree | 44c9e86c068a2f8e5e8d5a387693502a15e39788 /src/cmd/compile/internal/noder | |
| parent | a2e2b0362bb2e7b93de668007027d08888bc9a38 (diff) | |
| download | go-b27c7e30dc5d222766057e62c16cb765b636d244.tar.gz go-b27c7e30dc5d222766057e62c16cb765b636d244.zip | |
[dev.typeparams] cmd/compile: fix HasShape, add dottype test
HasShape needs a TINTER case.
Add a test for x.(T) in various situations. Needs the fix above.
Also remove ONEW unshapify case. It is ok for ONEW to have a shape
type, as it will just be passed to mallocgc, or possibly used as a
stack object type, both of which are ok.
Change-Id: Ibddf8f5c8c254d32cb5ebcaca7dc94b4c00ab893
Reviewed-on: https://go-review.googlesource.com/c/go/+/337231
Trust: Keith Randall <khr@golang.org>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder')
| -rw-r--r-- | src/cmd/compile/internal/noder/stencil.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/cmd/compile/internal/noder/stencil.go b/src/cmd/compile/internal/noder/stencil.go index f1de1152c5..575b879762 100644 --- a/src/cmd/compile/internal/noder/stencil.go +++ b/src/cmd/compile/internal/noder/stencil.go @@ -1376,12 +1376,6 @@ func (subst *subster) node(n ir.Node) ir.Node { case ir.ODOTTYPE, ir.ODOTTYPE2: m.SetType(subst.unshapifyTyp(m.Type())) - case ir.ONEW: - // New needs to pass a concrete type to the runtime. - // Or maybe it doesn't? We could use a shape type. - // TODO: need to modify m.X? I don't think any downstream passes use it. - m.SetType(subst.unshapifyTyp(m.Type())) - case ir.OMETHEXPR: se := m.(*ir.SelectorExpr) se.X = ir.TypeNodeAt(se.X.Pos(), subst.unshapifyTyp(se.X.Type())) |