diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-06-23 14:39:44 +0700 |
|---|---|---|
| committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-06-23 08:00:38 +0000 |
| commit | 107b1fce6401b7f5fa12f6e51746a2d0c86b65ca (patch) | |
| tree | 5212d1df251942a1caac9144026cb12ee744fe71 /src/cmd/compile/internal/noder/reader.go | |
| parent | 99732b9070ea23c13f7ed9ff8518304e34942ad4 (diff) | |
| download | go-107b1fce6401b7f5fa12f6e51746a2d0c86b65ca.tar.gz go-107b1fce6401b7f5fa12f6e51746a2d0c86b65ca.zip | |
[dev.typeparams] cmd/compile: explain why expandInline needed
Change-Id: Ica9817675b4eb929a000640f9ae873b75fc5a2e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/330290
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/noder/reader.go')
| -rw-r--r-- | src/cmd/compile/internal/noder/reader.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index b106e89892..df9dccc156 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -1956,8 +1956,9 @@ func (r *reader) inlReturn(ret *ir.ReturnStmt) *ir.BlockStmt { // expandInline reads in an extra copy of IR to populate // fn.Inl.{Dcl,Body}. func expandInline(fn *ir.Func, pri pkgReaderIndex) { - // TODO(mdempsky): Remove this function. It's currently needed for - // dwarfgen for some reason, but we should be able to provide it + // TODO(mdempsky): Remove this function. It's currently needed by + // dwarfgen/dwarf.go:preInliningDcls, which requires fn.Inl.Dcl to + // create abstract function DIEs. But we should be able to provide it // with the same information some other way. fndcls := len(fn.Dcl) |