aboutsummaryrefslogtreecommitdiff
path: root/src/cmd/compile/internal/arm
diff options
context:
space:
mode:
authorJosh Bleecher Snyder <josharian@gmail.com>2017-04-28 00:19:49 +0000
committerJosh Bleecher Snyder <josharian@gmail.com>2017-04-28 01:24:13 +0000
commitdae5389d3d2b5303542a6b699eff49307b7ed985 (patch)
tree3445d4990345f4e9c32d33cc0878b684ba63972c /src/cmd/compile/internal/arm
parent3a342af977ccf8604f49fc776d17c5f3f3e6d293 (diff)
downloadgo-dae5389d3d2b5303542a6b699eff49307b7ed985.tar.gz
go-dae5389d3d2b5303542a6b699eff49307b7ed985.zip
Revert "cmd/compile: add Type.MustSize and Type.MustAlignment"
This reverts commit 94d540a4b6bf68ec472bf4469037955e3133fcf7. Reason for revert: prefer something along the lines of CL 42018. Change-Id: I876fe32e98f37d8d725fe55e0fd0ea429c0198e0 Reviewed-on: https://go-review.googlesource.com/42022 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/cmd/compile/internal/arm')
-rw-r--r--src/cmd/compile/internal/arm/ggen.go2
-rw-r--r--src/cmd/compile/internal/arm/ssa.go18
2 files changed, 10 insertions, 10 deletions
diff --git a/src/cmd/compile/internal/arm/ggen.go b/src/cmd/compile/internal/arm/ggen.go
index ea02bc6f9e..b2fc272ec6 100644
--- a/src/cmd/compile/internal/arm/ggen.go
+++ b/src/cmd/compile/internal/arm/ggen.go
@@ -50,7 +50,7 @@ func zerorange(pp *gc.Progs, p *obj.Prog, off, cnt int64, r0 *uint32) *obj.Prog
func zeroAuto(pp *gc.Progs, n *gc.Node) {
// Note: this code must not clobber any registers.
sym := n.Sym.Linksym()
- size := n.Type.MustSize()
+ size := n.Type.Size()
p := pp.Prog(arm.AMOVW)
p.From.Type = obj.TYPE_CONST
p.From.Offset = 0
diff --git a/src/cmd/compile/internal/arm/ssa.go b/src/cmd/compile/internal/arm/ssa.go
index 8b51460908..ea9c3a9cc1 100644
--- a/src/cmd/compile/internal/arm/ssa.go
+++ b/src/cmd/compile/internal/arm/ssa.go
@@ -17,14 +17,14 @@ import (
// loadByType returns the load instruction of the given type.
func loadByType(t ssa.Type) obj.As {
if t.IsFloat() {
- switch t.MustSize() {
+ switch t.Size() {
case 4:
return arm.AMOVF
case 8:
return arm.AMOVD
}
} else {
- switch t.MustSize() {
+ switch t.Size() {
case 1:
if t.IsSigned() {
return arm.AMOVB
@@ -47,14 +47,14 @@ func loadByType(t ssa.Type) obj.As {
// storeByType returns the store instruction of the given type.
func storeByType(t ssa.Type) obj.As {
if t.IsFloat() {
- switch t.MustSize() {
+ switch t.Size() {
case 4:
return arm.AMOVF
case 8:
return arm.AMOVD
}
} else {
- switch t.MustSize() {
+ switch t.Size() {
case 1:
return arm.AMOVB
case 2:
@@ -130,7 +130,7 @@ func ssaGenValue(s *gc.SSAGenState, v *ssa.Value) {
}
as := arm.AMOVW
if v.Type.IsFloat() {
- switch v.Type.MustSize() {
+ switch v.Type.Size() {
case 4:
as = arm.AMOVF
case 8:
@@ -562,10 +562,10 @@ func ssaGenValue(s *gc.SSAGenState, v *ssa.Value) {
if a.Op == ssa.OpLoadReg {
t := a.Type
switch {
- case v.Op == ssa.OpARMMOVBreg && t.MustSize() == 1 && t.IsSigned(),
- v.Op == ssa.OpARMMOVBUreg && t.MustSize() == 1 && !t.IsSigned(),
- v.Op == ssa.OpARMMOVHreg && t.MustSize() == 2 && t.IsSigned(),
- v.Op == ssa.OpARMMOVHUreg && t.MustSize() == 2 && !t.IsSigned():
+ case v.Op == ssa.OpARMMOVBreg && t.Size() == 1 && t.IsSigned(),
+ v.Op == ssa.OpARMMOVBUreg && t.Size() == 1 && !t.IsSigned(),
+ v.Op == ssa.OpARMMOVHreg && t.Size() == 2 && t.IsSigned(),
+ v.Op == ssa.OpARMMOVHUreg && t.Size() == 2 && !t.IsSigned():
// arg is a proper-typed load, already zero/sign-extended, don't extend again
if v.Reg() == v.Args[0].Reg() {
return