diff options
| author | Keith Randall <khr@golang.org> | 2020-06-15 14:43:02 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2020-06-18 20:57:49 +0000 |
| commit | 40ef1faabc44ab8ea28a1cf282ecab723ecb0394 (patch) | |
| tree | 1c04bdc4b2eb3226759499dd6867c6771510ba75 /src/cmd/compile/internal/arm | |
| parent | 377c1536f548ae6295699475683db7574bea3d51 (diff) | |
| download | go-40ef1faabc44ab8ea28a1cf282ecab723ecb0394.tar.gz go-40ef1faabc44ab8ea28a1cf282ecab723ecb0394.zip | |
cmd/compile: redo flag constant ops for arm
Encode the flag results in an auxint field instead of having
one opcode per flag state. This helps us handle the new *noov
branches in a unified manner.
This is only for arm, arm64 is in a subsequent CL.
We could extend to other architectures as well, athough it would
only be cleanup, no behavioral change.
Update #39505
Change-Id: Ia46cea596faad540d1496c5915ab1274571543f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/238077
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'src/cmd/compile/internal/arm')
| -rw-r--r-- | src/cmd/compile/internal/arm/ssa.go | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/cmd/compile/internal/arm/ssa.go b/src/cmd/compile/internal/arm/ssa.go index 1da72aaf56..765a771546 100644 --- a/src/cmd/compile/internal/arm/ssa.go +++ b/src/cmd/compile/internal/arm/ssa.go @@ -857,12 +857,8 @@ func ssaGenValue(s *gc.SSAGenState, v *ssa.Value) { p := s.Prog(obj.AGETCALLERPC) p.To.Type = obj.TYPE_REG p.To.Reg = v.Reg() - case ssa.OpARMFlagEQ, - ssa.OpARMFlagLT_ULT, - ssa.OpARMFlagLT_UGT, - ssa.OpARMFlagGT_ULT, - ssa.OpARMFlagGT_UGT: - v.Fatalf("Flag* ops should never make it to codegen %v", v.LongString()) + case ssa.OpARMFlagConstant: + v.Fatalf("FlagConstant op should never make it to codegen %v", v.LongString()) case ssa.OpARMInvertFlags: v.Fatalf("InvertFlags should never make it to codegen %v", v.LongString()) case ssa.OpClobber: |