diff options
| author | Jeet Parekh <jeetparekh96@gmail.com> | 2018-08-01 02:47:01 +0000 |
|---|---|---|
| committer | Joe Tsai <thebrokentoaster@gmail.com> | 2018-08-21 00:34:36 +0000 |
| commit | 539ff607a70bb6f7f12b1bca6b365ab0af448fcf (patch) | |
| tree | 3b24e4b322dbbf94d1dadada593d193e13983512 /src/archive/zip/reader_test.go | |
| parent | 0b30cf534a03618162d3015c8705dd2231e34703 (diff) | |
| download | go-539ff607a70bb6f7f12b1bca6b365ab0af448fcf.tar.gz go-539ff607a70bb6f7f12b1bca6b365ab0af448fcf.zip | |
archive/zip: return error from NewReader when negative size is passed
Fixes #26589
Change-Id: I180883a13cec229093654004b42c48d76ee20272
GitHub-Last-Rev: 2d9879de43fbcfb413116d69accdade6bc042c97
GitHub-Pull-Request: golang/go#26667
Reviewed-on: https://go-review.googlesource.com/126617
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/archive/zip/reader_test.go')
| -rw-r--r-- | src/archive/zip/reader_test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/archive/zip/reader_test.go b/src/archive/zip/reader_test.go index 1e58b26b6e..6b3f2f33bb 100644 --- a/src/archive/zip/reader_test.go +++ b/src/archive/zip/reader_test.go @@ -658,6 +658,12 @@ func TestInvalidFiles(t *testing.T) { if err != ErrFormat { t.Errorf("sigs: error=%v, want %v", err, ErrFormat) } + + // negative size + _, err = NewReader(bytes.NewReader([]byte("foobar")), -1) + if err == nil { + t.Errorf("archive/zip.NewReader: expected error when negative size is passed") + } } func messWith(fileName string, corrupter func(b []byte)) (r io.ReaderAt, size int64) { |