diff options
| author | Dmitri Shuralyov <dmitshur@golang.org> | 2021-12-06 18:05:53 -0500 |
|---|---|---|
| committer | Dmitri Shuralyov <dmitshur@golang.org> | 2021-12-07 00:03:34 +0000 |
| commit | 79b425e9fca11d189142504bc81cf4e009092f6d (patch) | |
| tree | 97d46644726d42d705351115d5c0a5f95f85e00f /misc | |
| parent | 871d63fb73476bc3bf52ceec9aa8bef3ffc85d51 (diff) | |
| download | go-79b425e9fca11d189142504bc81cf4e009092f6d.tar.gz go-79b425e9fca11d189142504bc81cf4e009092f6d.zip | |
misc/cgo/testplugin: remove skip in TestIssue25756pie
Though this was a problem for Go 1.17,
it appears not to be a problem on tip.
This reverts change made in CL 321349.
For #46239.
Change-Id: Ie4d6649fbabce3bb2c1cf04d97760ba6ceadaca5
Reviewed-on: https://go-review.googlesource.com/c/go/+/369752
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Diffstat (limited to 'misc')
| -rw-r--r-- | misc/cgo/testplugin/plugin_test.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/misc/cgo/testplugin/plugin_test.go b/misc/cgo/testplugin/plugin_test.go index 9697dbf7a7..a6accc1dfb 100644 --- a/misc/cgo/testplugin/plugin_test.go +++ b/misc/cgo/testplugin/plugin_test.go @@ -265,10 +265,6 @@ func TestIssue25756(t *testing.T) { // Test with main using -buildmode=pie with plugin for issue #43228 func TestIssue25756pie(t *testing.T) { - if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" { - t.Skip("broken on darwin/arm64 builder in sharded mode; see issue 46239") - } - goCmd(t, "build", "-buildmode=plugin", "-o", "life.so", "./issue25756/plugin") goCmd(t, "build", "-buildmode=pie", "-o", "issue25756pie.exe", "./issue25756/main.go") run(t, "./issue25756pie.exe") |