aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@golang.org>2016-07-06 21:29:40 +0000
committerBrad Fitzpatrick <bradfitz@golang.org>2016-07-07 04:06:52 +0000
commitd8722012afb789f1a2875a0d2ed50bfbae12bb9c (patch)
tree420fc73e9d79ad067117ab5d733517323fa6d018 /lib
parentdf7c159f06ab6d6c7ac6c953e491f8900f40d282 (diff)
downloadgo-d8722012afb789f1a2875a0d2ed50bfbae12bb9c.tar.gz
go-d8722012afb789f1a2875a0d2ed50bfbae12bb9c.zip
net/http: deflake TestClientRedirectContext
The test was checking for 1 of 2 possible error values. But based on goroutine scheduling and the randomness of select statement receive cases, it was possible for a 3rd type of error to be returned. This modifies the code (not the test) to make that third type of error actually the second type of error, which is a nicer error message. The test is no longer flaky. The flake was very reproducible with a 5ms sleep before the select at the end of Transport.getConn. Thanks to Github user @jaredborner for debugging. Fixes #16049 Change-Id: I0d2a036c9555a8d2618b07bab01f28558d2b0b2c Reviewed-on: https://go-review.googlesource.com/24748 Reviewed-by: Andrew Gerrand <adg@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions