diff options
| author | Russ Cox <rsc@golang.org> | 2014-02-13 05:06:46 +0000 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-02-13 05:06:46 +0000 |
| commit | 673917f87879e32e81e55b3cc5fa027a5c8fce0a (patch) | |
| tree | 1d6fe79caa2f4393ff018f1bdb73f6050e91506f /lib | |
| parent | 37bf90024b5cce75fab905fef7c73f9fce5628be (diff) | |
| download | go-673917f87879e32e81e55b3cc5fa027a5c8fce0a.tar.gz go-673917f87879e32e81e55b3cc5fa027a5c8fce0a.zip | |
codereview: warn about 'hg upload' not uploading
This seems to be what causes the 'chunk mismatch' errors.
I don't know why the server tells us there's nothing to upload,
but at the least we can warn that it did, so that the user
will try again.
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/62840043
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/codereview/codereview.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index d171ef3e99..18ecc141d2 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -367,6 +367,8 @@ class CL(object): msg = lines[0] patchset = lines[1].strip() patches = [x.split(" ", 1) for x in lines[2:]] + else: + print >>sys.stderr, "Server says there is nothing to upload (probably wrong):\n" + msg if response_body.startswith("Issue updated.") and quiet: pass else: |