diff options
| author | Shenghou Ma <minux@golang.org> | 2014-07-18 21:04:56 -0400 |
|---|---|---|
| committer | Shenghou Ma <minux@golang.org> | 2014-07-18 21:04:56 -0400 |
| commit | 09a9ef61153227307d00e5bffae106d66b400858 (patch) | |
| tree | f88d011875a5dfe8a24f8af48cf65f091e2fd5ce /lib | |
| parent | 9a8a20bdb831144a2e12c3d6f2ac32d7c94e7b21 (diff) | |
| download | go-09a9ef61153227307d00e5bffae106d66b400858.tar.gz go-09a9ef61153227307d00e5bffae106d66b400858.zip | |
codereview: abort 'hg commit' before entering commit message.
Hook pre-commit runs before 'hg commit' command whereas hook precommit runs
after the user has entered commit message.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/106320043
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/codereview/codereview.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 8445555fa2..116d313b01 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -2289,6 +2289,10 @@ codereview_init = False def uisetup(ui): global testing testing = ui.config("codereview", "testing") + # Disable the Mercurial commands that might change the repository. + # Only commands in this extension are supposed to do that. + ui.setconfig("hooks", "pre-commit.codereview", precommithook) # runs before 'hg commit' + ui.setconfig("hooks", "precommit.codereview", precommithook) # catches all cases def reposetup(ui, repo): global codereview_disabled @@ -2338,10 +2342,6 @@ def reposetup(ui, repo): InstallMatch(ui, repo) RietveldSetup(ui, repo) - # Disable the Mercurial commands that might change the repository. - # Only commands in this extension are supposed to do that. - ui.setconfig("hooks", "precommit.codereview", precommithook) - # Rollback removes an existing commit. Don't do that either. global real_rollback real_rollback = repo.rollback |