diff options
| author | Russ Cox <rsc@golang.org> | 2014-06-05 16:40:09 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-06-05 16:40:09 -0400 |
| commit | 32a5c898e3bd7d3abf1b6f6dc5ef4a23c5d32d8f (patch) | |
| tree | fab3bd60f54931a9aaadaa2d0ec9753c0213c4d9 /lib | |
| parent | c22ed1290c55e7ca0e8cbd7028ddd4c397a71174 (diff) | |
| download | go-32a5c898e3bd7d3abf1b6f6dc5ef4a23c5d32d8f.tar.gz go-32a5c898e3bd7d3abf1b6f6dc5ef4a23c5d32d8f.zip | |
codereview: do not add defaultcc for private CLs
LGTM=r
R=r, 0xjnml, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/103070046
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/codereview/codereview.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 67341ebc37..936e0b685a 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -846,7 +846,7 @@ def CommandLineCL(ui, repo, pats, opts, op="verb", defaultcc=None): cl.reviewer = Add(cl.reviewer, SplitCommaSpace(opts.get('reviewer'))) if opts.get('cc'): cl.cc = Add(cl.cc, SplitCommaSpace(opts.get('cc'))) - if defaultcc: + if defaultcc and not cl.private: cl.cc = Add(cl.cc, defaultcc) if cl.name == "new": if opts.get('message'): @@ -1845,7 +1845,7 @@ def mail(ui, repo, *pats, **opts): # This makes sure that it appears in the # codereview.appspot.com/user/defaultcc # page, so that it doesn't get dropped on the floor. - if not defaultcc: + if not defaultcc or cl.private: raise hg_util.Abort("no reviewers listed in CL") cl.cc = Sub(cl.cc, defaultcc) cl.reviewer = defaultcc |