aboutsummaryrefslogtreecommitdiff
path: root/lib/time
diff options
context:
space:
mode:
authorCherry Zhang <cherryyz@google.com>2020-12-15 18:31:21 -0500
committerCarlos Amedee <carlos@golang.org>2021-06-10 20:01:45 +0000
commitb4a2af26baa7e0eb28dd0fd88147f2c87604696e (patch)
tree58d3471711b86a139048f389d358977133c7a276 /lib/time
parentab7f8297f9734b24a43a942930258cda411f16a3 (diff)
downloadgo-b4a2af26baa7e0eb28dd0fd88147f2c87604696e.tar.gz
go-b4a2af26baa7e0eb28dd0fd88147f2c87604696e.zip
[release-branch.go1.15] cmd/link: pass arch-specific flags to external linker when testing supported flag
When testing if a flag (e.g. "-no-pie") is supported by the external linker, pass arch-specific flags (like "-marm"). In particular, on the ARM builder, if CGO_LDFLAGS=-march=armv6 is set, the C toolchain fails to build if -marm is not passed. # cc -march=armv6 1.c 1.c: In function 'main': 1.c:3:1: sorry, unimplemented: Thumb-1 hard-float VFP ABI int main() { ^~~ This makes the Go linker think "-no-pie" is not supported when it actually is. Passing -marm makes it work. Fixes #46684. Change-Id: I4e8b71f08818993cbbcb2494b310c68d812d6b50 Reviewed-on: https://go-review.googlesource.com/c/go/+/278592 Trust: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> (cherry picked from commit a318d56c1e6e89996a3852a780f45c792d860d64) Reviewed-on: https://go-review.googlesource.com/c/go/+/326711 Run-TryBot: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org>
Diffstat (limited to 'lib/time')
0 files changed, 0 insertions, 0 deletions