aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrey Mirtchovski <mirtchovski@gmail.com>2011-10-18 14:51:40 -0400
committerRuss Cox <rsc@golang.org>2011-10-18 14:51:40 -0400
commit565793996c2b646dfa31c6660d79a57a7ae8312e (patch)
tree6ab85efdcf2059cd309d1f55e80fe4cf78203c29
parent48bb3e8f2883609ca56ea8afc0c11f141f4ec227 (diff)
downloadgo-565793996c2b646dfa31c6660d79a57a7ae8312e.tar.gz
go-565793996c2b646dfa31c6660d79a57a7ae8312e.zip
net: remove duplicate error information in Dial
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5293045
-rw-r--r--src/pkg/net/dial.go4
-rw-r--r--src/pkg/net/net_test.go6
2 files changed, 8 insertions, 2 deletions
diff --git a/src/pkg/net/dial.go b/src/pkg/net/dial.go
index 10c67dcc40..85d54b3703 100644
--- a/src/pkg/net/dial.go
+++ b/src/pkg/net/dial.go
@@ -59,10 +59,10 @@ func Dial(net, addr string) (c Conn, err os.Error) {
case *IPAddr:
c, err = DialIP(net, nil, ra)
default:
- err = UnknownNetworkError(net)
+ err = &OpError{"dial", net + " " + addr, nil, UnknownNetworkError(net)}
}
if err != nil {
- return nil, &OpError{"dial", net + " " + addr, nil, err}
+ return nil, err
}
return
}
diff --git a/src/pkg/net/net_test.go b/src/pkg/net/net_test.go
index e4d7a253e2..3754bc90b3 100644
--- a/src/pkg/net/net_test.go
+++ b/src/pkg/net/net_test.go
@@ -62,6 +62,8 @@ var dialErrorTests = []DialErrorTest{
},
}
+var duplicateErrorPattern = `dial (.*) dial (.*)`
+
func TestDialError(t *testing.T) {
if !*runErrorTest {
t.Logf("test disabled; use --run_error_test to enable")
@@ -81,6 +83,10 @@ func TestDialError(t *testing.T) {
if !match {
t.Errorf("#%d: %q, want match for %#q", i, s, tt.Pattern)
}
+ match, _ = regexp.MatchString(duplicateErrorPattern, s)
+ if match {
+ t.Errorf("#%d: %q, duplicate error return from Dial", i, s)
+ }
}
}