diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2011-06-20 14:36:03 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2011-06-20 14:36:03 -0700 |
| commit | 9ee83f546fb1febfb580030c8c6e5d2eebe721d2 (patch) | |
| tree | 83c3dab8d15a267fec4fdd226f850f0306a94b75 | |
| parent | 922ceaddd21289e90b35924b74cc6163a34ab40a (diff) | |
| download | go-9ee83f546fb1febfb580030c8c6e5d2eebe721d2.tar.gz go-9ee83f546fb1febfb580030c8c6e5d2eebe721d2.zip | |
http: write Header keys with empty values
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/4630052
| -rw-r--r-- | src/pkg/http/header.go | 3 | ||||
| -rw-r--r-- | src/pkg/http/header_test.go | 10 |
2 files changed, 10 insertions, 3 deletions
diff --git a/src/pkg/http/header.go b/src/pkg/http/header.go index 95140b01f2..95a25a814b 100644 --- a/src/pkg/http/header.go +++ b/src/pkg/http/header.go @@ -62,9 +62,6 @@ func (h Header) WriteSubset(w io.Writer, exclude map[string]bool) os.Error { v = strings.Replace(v, "\n", " ", -1) v = strings.Replace(v, "\r", " ", -1) v = strings.TrimSpace(v) - if v == "" { - continue - } if _, err := fmt.Fprintf(w, "%s: %s\r\n", k, v); err != nil { return err } diff --git a/src/pkg/http/header_test.go b/src/pkg/http/header_test.go index 7e24cb069c..ccdee8a97b 100644 --- a/src/pkg/http/header_test.go +++ b/src/pkg/http/header_test.go @@ -57,6 +57,16 @@ var headerWriteTests = []struct { map[string]bool{"Content-Length": true, "Expires": true, "Content-Encoding": true}, "", }, + { + Header{ + "Nil": nil, + "Empty": {}, + "Blank": {""}, + "Double-Blank": {"", ""}, + }, + nil, + "Blank: \r\nDouble-Blank: \r\nDouble-Blank: \r\n", + }, } func TestHeaderWrite(t *testing.T) { |