diff options
| author | Russ Cox <rsc@golang.org> | 2011-02-23 15:42:13 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2011-02-23 15:42:13 -0500 |
| commit | 59ce067da8d9e7d968e51f31fb532ed2369f205a (patch) | |
| tree | b75d130f5edf0f96a23f68d7af8e131833f70d69 | |
| parent | e0a2c5d4b540934e06867710fe7137661a2a39ec (diff) | |
| download | go-59ce067da8d9e7d968e51f31fb532ed2369f205a.tar.gz go-59ce067da8d9e7d968e51f31fb532ed2369f205a.zip | |
runtime: omit breakpoint during terminal panic
A terminal panic (one that prints a stack trace and exits)
has been calling runtime.breakpoint before calling exit,
so that if running under a debugger, the debugger can
take control. When not running under a debugger, though,
this causes an additional SIGTRAP on Unix and pop-up
dialogs on Windows.
Support for debugging Go programs has gotten good
enough that we can rely on the debugger to set its own
breakpoint on runtime.exit if it wants to look around.
R=r, r2
CC=golang-dev
https://golang.org/cl/4222043
| -rw-r--r-- | src/pkg/runtime/darwin/386/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/darwin/amd64/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/freebsd/386/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/freebsd/amd64/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/linux/386/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/linux/amd64/signal.c | 1 | ||||
| -rw-r--r-- | src/pkg/runtime/windows/386/signal.c | 1 |
7 files changed, 0 insertions, 7 deletions
diff --git a/src/pkg/runtime/darwin/386/signal.c b/src/pkg/runtime/darwin/386/signal.c index dd3050f033..aeef5de3fc 100644 --- a/src/pkg/runtime/darwin/386/signal.c +++ b/src/pkg/runtime/darwin/386/signal.c @@ -107,7 +107,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/darwin/amd64/signal.c b/src/pkg/runtime/darwin/amd64/signal.c index d12b12f3e6..402ab33ca0 100644 --- a/src/pkg/runtime/darwin/amd64/signal.c +++ b/src/pkg/runtime/darwin/amd64/signal.c @@ -117,7 +117,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/freebsd/386/signal.c b/src/pkg/runtime/freebsd/386/signal.c index bf40c8bd02..8e9d742564 100644 --- a/src/pkg/runtime/freebsd/386/signal.c +++ b/src/pkg/runtime/freebsd/386/signal.c @@ -103,7 +103,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/freebsd/amd64/signal.c b/src/pkg/runtime/freebsd/amd64/signal.c index b2313fad32..f145371b47 100644 --- a/src/pkg/runtime/freebsd/amd64/signal.c +++ b/src/pkg/runtime/freebsd/amd64/signal.c @@ -111,7 +111,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/linux/386/signal.c b/src/pkg/runtime/linux/386/signal.c index 7f20d058b8..bd918c7ea5 100644 --- a/src/pkg/runtime/linux/386/signal.c +++ b/src/pkg/runtime/linux/386/signal.c @@ -100,7 +100,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/linux/amd64/signal.c b/src/pkg/runtime/linux/amd64/signal.c index 462f9a74d7..ea0932523e 100644 --- a/src/pkg/runtime/linux/amd64/signal.c +++ b/src/pkg/runtime/linux/amd64/signal.c @@ -110,7 +110,6 @@ runtime·sighandler(int32 sig, Siginfo *info, void *context, G *gp) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); } diff --git a/src/pkg/runtime/windows/386/signal.c b/src/pkg/runtime/windows/386/signal.c index 9036369102..08b32a137b 100644 --- a/src/pkg/runtime/windows/386/signal.c +++ b/src/pkg/runtime/windows/386/signal.c @@ -85,7 +85,6 @@ runtime·sighandler(ExceptionRecord *info, void *frame, Context *r) runtime·dumpregs(r); } - runtime·breakpoint(); runtime·exit(2); return 0; } |