diff options
| author | Ryan Hitchman <hitchmanr@gmail.com> | 2011-01-19 14:46:06 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2011-01-19 14:46:06 -0500 |
| commit | 30c85bf14c32a836e666542b78a961e1e8fdc346 (patch) | |
| tree | b7e1ae2b42819c1369b4fd9199214a85d55ac1ea | |
| parent | 3a97119517423b8ba5e172d4101f273c0cbea86e (diff) | |
| download | go-30c85bf14c32a836e666542b78a961e1e8fdc346.tar.gz go-30c85bf14c32a836e666542b78a961e1e8fdc346.zip | |
codereview: don't mail change lists with no files
R=rsc
CC=golang-dev
https://golang.org/cl/3561041
| -rw-r--r-- | lib/codereview/codereview.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index e8c84abec2..0a345d8f66 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1134,8 +1134,12 @@ def mail(ui, repo, *pats, **opts): return "no reviewers listed in CL" cl.cc = Sub(cl.cc, defaultcc) cl.reviewer = defaultcc - cl.Flush(ui, repo) - cl.Mail(ui, repo) + cl.Flush(ui, repo) + + if cl.files == []: + return "no changed files, not sending mail" + + cl.Mail(ui, repo) def nocommit(ui, repo, *pats, **opts): """(disabled when using this extension)""" |