aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHector Chu <hectorchu@gmail.com>2011-01-19 19:02:47 -0500
committerRuss Cox <rsc@golang.org>2011-01-19 19:02:47 -0500
commit1e0efcd5790be98f72c53bfd6c4061bafaafdafc (patch)
tree2b1a7adfa6a0ed699a06930bfb85a5a8f1b08020
parenta441037f3f7aedc419595c8a5e032723cedbdeb3 (diff)
downloadgo-1e0efcd5790be98f72c53bfd6c4061bafaafdafc.tar.gz
go-1e0efcd5790be98f72c53bfd6c4061bafaafdafc.zip
codereview: fix hg change on Windows
hg change fails on Windows with 'No valid patches found in output from hg diff'. R=rsc CC=golang-dev https://golang.org/cl/4006043
-rw-r--r--lib/codereview/codereview.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 0a345d8f66..ab8415e087 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -2607,7 +2607,7 @@ class MercurialVCS(VersionControlSystem):
self.base_rev = self.options.revision
else:
mqparent, err = RunShellWithReturnCode(['hg', 'log', '--rev', 'qparent', '--template={node}'])
- if not err:
+ if not err and mqparent != "":
self.base_rev = mqparent
else:
self.base_rev = RunShell(["hg", "parents", "-q"]).split(':')[1].strip()