diff options
| author | Sebastien Binet <seb.binet@gmail.com> | 2010-12-27 10:05:32 -0800 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2010-12-27 10:05:32 -0800 |
| commit | 33145c48682523177ac1cf62ee6b86eed680fffa (patch) | |
| tree | 017b016e7a55908b6fb1ea200830987bc89a181e | |
| parent | 03e259664f778ca55fe348afb5e6a43459ffbcce (diff) | |
| download | go-33145c48682523177ac1cf62ee6b86eed680fffa.tar.gz go-33145c48682523177ac1cf62ee6b86eed680fffa.zip | |
simple fix to not have 'exp/eval' panic in presence of slices like s[:2]
R=golang-dev, gri
CC=binet, golang-dev
https://golang.org/cl/3782044
| -rw-r--r-- | src/pkg/exp/eval/expr.go | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/pkg/exp/eval/expr.go b/src/pkg/exp/eval/expr.go index 66adeef957..f633aea390 100644 --- a/src/pkg/exp/eval/expr.go +++ b/src/pkg/exp/eval/expr.go @@ -595,9 +595,15 @@ func (a *exprCompiler) compile(x ast.Expr, callCtx bool) *expr { return ei.compileIndexExpr(l, r) case *ast.SliceExpr: - var hi *expr + var lo, hi *expr arr := a.compile(x.X, false) - lo := a.compile(x.Index, false) + if x.Index == nil { + // beginning was omitted, so we need to provide it + ei := &exprInfo{a.compiler, x.Pos()} + lo = ei.compileIntLit("0") + } else { + lo = a.compile(x.Index, false) + } if x.End == nil { // End was omitted, so we need to compute len(x.X) ei := &exprInfo{a.compiler, x.Pos()} |