aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Pike <r@golang.org>2010-12-20 13:36:47 -0800
committerRob Pike <r@golang.org>2010-12-20 13:36:47 -0800
commitd3866ddc65789d1dbdbb90e4bedafcf0bfc65c87 (patch)
tree020f2d5053658f4b7e2e58d35856d7deea335956
parent8bfa9175a3937cbcb144b53464d46040345c467c (diff)
downloadgo-d3866ddc65789d1dbdbb90e4bedafcf0bfc65c87.tar.gz
go-d3866ddc65789d1dbdbb90e4bedafcf0bfc65c87.zip
template: fix trivial bug: integers are not "empty"
Fixes #1357. R=adg, gri CC=golang-dev https://golang.org/cl/3809041
-rw-r--r--src/pkg/template/template.go2
-rw-r--r--src/pkg/template/template_test.go6
2 files changed, 7 insertions, 1 deletions
diff --git a/src/pkg/template/template.go b/src/pkg/template/template.go
index be5c59aed8..aa05077616 100644
--- a/src/pkg/template/template.go
+++ b/src/pkg/template/template.go
@@ -673,7 +673,7 @@ func empty(v reflect.Value) bool {
case *reflect.SliceValue:
return v.Len() == 0
}
- return true
+ return false
}
// Look up a variable or method, up through the parent if necessary.
diff --git a/src/pkg/template/template_test.go b/src/pkg/template/template_test.go
index 1c491e34ae..4075444a81 100644
--- a/src/pkg/template/template_test.go
+++ b/src/pkg/template/template_test.go
@@ -197,6 +197,12 @@ var tests = []*Test{
out: " Header\n",
},
+ &Test{
+ in: "{.section integer}{@}{.end}",
+
+ out: "77",
+ },
+
// Repeated
&Test{
in: "{.section pdata }\n" +